Skip to content

enhance FFTW easyblock to skip tests if --mpi-tests EasyBuild configuration option is disabled#2490

Merged
boegel merged 1 commit intoeasybuilders:developfrom
willfurnass:fftw-allow-disable-mpi-tests
Jun 28, 2021
Merged

enhance FFTW easyblock to skip tests if --mpi-tests EasyBuild configuration option is disabled#2490
boegel merged 1 commit intoeasybuilders:developfrom
willfurnass:fftw-allow-disable-mpi-tests

Conversation

@willfurnass
Copy link
Copy Markdown
Contributor

Addresses #1100

Q: what's the idiomatic way to add a check for the toolchain having an MPI?

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jun 25, 2021

One way would be

if self.toolchain.mpi_family():

mpi_family() either returns the MPI family (OpenMPI/MPICH) or None is it is not defined

@willfurnass willfurnass force-pushed the fftw-allow-disable-mpi-tests branch from cae76db to 9a7cd36 Compare June 25, 2021 11:49
@willfurnass
Copy link
Copy Markdown
Contributor Author

Thanks @ocaisa!

@boegel boegel changed the title FFTW: allow disabling of tests if using MPI allow disabling of tests if using MPI in FFTW easyblock Jun 28, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jun 28, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 28, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS FFTW-3.3.9-gompi-2021a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2603.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/5bf56cb4507308586622ed8937ad06a7 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 2112516 into easybuilders:develop Jun 28, 2021
@boegel boegel changed the title allow disabling of tests if using MPI in FFTW easyblock enhance FFTW easyblock to skip tests if --mpi-tests EasyBuild configuration option is disabled Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants