Skip to content

adjust qa list in WIEN2k easyblock to handle new questions + fix sanity check for v21.1#2572

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20210910133314_new_pr_wien2k
Sep 11, 2021
Merged

adjust qa list in WIEN2k easyblock to handle new questions + fix sanity check for v21.1#2572
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20210910133314_new_pr_wien2k

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren akesandgren changed the title wien2k: adjust qa list to handle new questions. Revert sanity check list for _mpi binaries to old list. wien2k: adjust qa list to handle new questions. Sep 10, 2021
@akesandgren akesandgren added this to the 4.x milestone Sep 10, 2021
@boegel boegel changed the title wien2k: adjust qa list to handle new questions. adjust qa list in WIEN2k easyblock to handle new questions Sep 11, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2021

@akesandgren Do you have access to the sources for all WIEN2k versions that we have easyconfigs for?

Since you're also removing questions, it would be nice to get good coverage in testing existing WIEN2k easyconfigs for this...

@akesandgren
Copy link
Copy Markdown
Contributor Author

The removal is just a simplification, the two removed ones end in the same thing as the "added" one.

@akesandgren
Copy link
Copy Markdown
Contributor Author

And to actually answer your question, I only have src for 21.1

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2021

@akesandgren Then please submit a test report with WIEN2k 21.1

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2021

@akesandgren Ah, that's actually done already in easybuilders/easybuild-easyconfigs#13972, nevermind :)

@boegel boegel changed the title adjust qa list in WIEN2k easyblock to handle new questions adjust qa list in WIEN2k easyblock to handle new questions + fix sanity check for v21.1 Sep 11, 2021
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS WIEN2k-19.2-intel-2020b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2605.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d666832dfe774856ce1f2b7129bb7bf4 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.4.3?) Sep 11, 2021
@boegel boegel merged commit 248c3c6 into easybuilders:develop Sep 11, 2021
@akesandgren akesandgren deleted the 20210910133314_new_pr_wien2k branch September 11, 2021 19:01
@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

Build succeeded for 4 out of 5 (5 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/c44bb161b698b82abbd857409285939b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 12, 2021

@migueldiascosta

== 2021-09-12 15:43:35,433 run.py:233 INFO running cmd: run_lapw -i 3 
== 2021-09-12 15:43:37,477 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): cmd "run_lapw -i 3" exited with exit code 9 and output:
 LAPW0 END
SECLR4 - Error
grep: lapw2*.error: No such file or directory

Did we break something? If so, please open an issue to follow up (and tag it with next release)

@migueldiascosta
Copy link
Copy Markdown
Member

@boegel I think this is related to the number of openmp threads used and only in that particular version, let me check

(I think in general we should limit the number of threads used in the test case (above I was using 4) because it can be painfully slow to use many more, but it should work with a few threads per process, and it does in the other versions...)

@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

  • SUCCESS WIEN2k-19.1-intel-2019a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/ecf5e0a0692f2df374ea3bf66e6cc6c2 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants