update PyTorch easyblock to configure without breakpad support on POWER#2763
Merged
branfosj merged 2 commits intoeasybuilders:developfrom Jul 20, 2022
Merged
Conversation
When comparing a `LooseVersion` instance against a string the string is automatically converted to a `LooseVersion` instance. Hence we can construct a `LooseVersion` object once and compare against strings in the condition which makes the code more readable.
Member
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Member
|
Going in, thanks @Flamefire! |
boegel
changed the title
boegel
reviewed
Aug 3, 2022
| if min_version and pytorch_version < min_version: | ||
| result = False | ||
| if max_version and pytorch_version >= LooseVersion(max_version): | ||
| if max_version and pytorch_version >= max_version: |
Member
There was a problem hiding this comment.
@Flamefire Did you check if automatically "casting" a string value to a LooseVersion object is also done in Python 2.7 when versions are being compared?
Contributor
Author
There was a problem hiding this comment.
Yes:
$ python2
Python 2.7.18 (default, Jul 1 2022, 12:27:04)
[GCC 9.4.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from distutils.version import LooseVersion
>>> LooseVersion('1.0') == '1.0'
True
>>> LooseVersion('1.0') != '1.0'
False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Breakpad (Added in 1.10, removed in 1.12.0) doesn't support PPC