add support for allowing version mismatch + consider versionsuffix when creating .modulerc in ModuleRC easyblock#3028
Merged
akesandgren merged 1 commit intoeasybuilders:developfrom Oct 30, 2023
Conversation
1 task
boegel
changed the title
ModuleRC easyblock
akesandgren
approved these changes
Oct 30, 2023
Contributor
akesandgren
left a comment
akesandgren
left a comment
There was a problem hiding this comment.
LGTM, doesn't change behavior for existing easyconfigs in the EB repo at least.
Contributor
|
Going in, thanks @Micket! |
boegel
changed the title
ModuleRC easyblock.modulerc in ModuleRC easyblock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)I want to provide alternative version strings for software like STAR-CCM+, which has a user facing version string like "2310" and a internal version used on the source itself like "18.06.006". This works fine in .modulerc, and it's just the extra check that the easyblock does that needlessly prevents this.
It also was missing version suffix of the symbolic version string, so that's just a bug fix.
With this, it now works by producing something like
See easybuilders/easybuild-easyconfigs#19100 for test case and test report.