Skip to content

new easyblock for DualSPHysics#3050

Merged
akesandgren merged 6 commits intoeasybuilders:developfrom
jfgrimm:20231212112825_new_pr_dualsphysics
Jan 8, 2024
Merged

new easyblock for DualSPHysics#3050
akesandgren merged 6 commits intoeasybuilders:developfrom
jfgrimm:20231212112825_new_pr_dualsphysics

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Dec 12, 2023

When building with EasyBuild configured to use rpath, the sanity checks for the existing easyconfig fail because some prebuilt binaries and libraries are bundled in the tarball, and these don't have an RPATH section. The new easyblock runs patchelf to add a corresponding entry.

corresponding easyconfigs PR: easybuilders/easybuild-easyconfigs#19400

(created using eb --new-pr)

@jfgrimm jfgrimm added the new label Dec 12, 2023
@jfgrimm jfgrimm added this to the 4.x milestone Dec 12, 2023
@jfgrimm jfgrimm changed the title new easyblock for dualsphysics new easyblock for DualSPHysics Dec 12, 2023
Comment thread easybuild/easyblocks/d/dualsphysics.py Outdated
Comment thread easybuild/easyblocks/d/dualsphysics.py Outdated
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Jan 4, 2024

successful report:
easybuilders/easybuild-easyconfigs#19400 (comment)

Comment thread easybuild/easyblocks/d/dualsphysics.py Outdated
@jfgrimm jfgrimm requested a review from akesandgren January 6, 2024 16:17
@akesandgren
Copy link
Copy Markdown
Contributor

Tested version of DualSPHysics-5.0.175-GCC-11.2.0.eb before using this easyblock (which fails) and the version from easybuilders/easybuild-easyconfigs#19400 (which works)

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren modified the milestones: 4.x, release after 4.9.0 Jan 8, 2024
@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @jfgrimm!

@akesandgren akesandgren merged commit 6d1c93f into easybuilders:develop Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants