Skip to content

replace run_cmd with run_shell_cmd in custom easyblock for cryptography (cryptography.py)#3107

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240129144444_new_pr_cryptography
Jan 30, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for cryptography (cryptography.py)#3107
boegel merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:20240129144444_new_pr_cryptography

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 29, 2024

(created using eb --new-pr)

  • No use of EB_cryptography in easyconfigs or blocks

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS cryptography-41.0.1-GCCcore-12.3.0.eb
  • SUCCESS Python-3.9.6-GCCcore-11.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-10.2.0.eb
  • SUCCESS poetry-1.6.1-GCCcore-13.2.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/af84c6e992c1991d10a2d2041a436324 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 30, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH="5.0.x"
EB_ARGS="cryptography-41.0.1-GCCcore-12.3.0.eb cryptography-41.0.5-GCCcore-13.2.0.eb --installpath /tmp/$USER/pr3107"

@boegelbot
Copy link
Copy Markdown

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3107 EB_ARGS="cryptography-41.0.1-GCCcore-12.3.0.eb cryptography-41.0.5-GCCcore-13.2.0.eb --installpath /tmp/$USER/pr3107" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3107 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3513

Test results coming soon (I hope)...

Details

- notification for comment with ID 1916194355 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS cryptography-41.0.1-GCCcore-12.3.0.eb
  • SUCCESS cryptography-41.0.5-GCCcore-13.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/15a1a3644de06e3c06fdd96c89501148 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 15ac0d5 into easybuilders:5.0.x Jan 30, 2024
@branfosj branfosj deleted the 20240129144444_new_pr_cryptography branch January 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants