Skip to content

fix OpenFOAM easyblock to fix motorBike example in sanity check for versions >=11#3232

Merged
boegel merged 8 commits intoeasybuilders:developfrom
Neves-P:openfoam
Mar 26, 2024
Merged

fix OpenFOAM easyblock to fix motorBike example in sanity check for versions >=11#3232
boegel merged 8 commits intoeasybuilders:developfrom
Neves-P:openfoam

Conversation

@Neves-P
Copy link
Copy Markdown
Contributor

@Neves-P Neves-P commented Feb 26, 2024

Relaxes the check of .org/.com forks to allow higher version numbers in .org case.
Corrects paths and functions called in motorBike example in the sanity check step for OpenFOAM v>=11. Without these changes the motorBike sanity check step won't run on versions 11 and above.

@boegel boegel added the bug fix label Feb 27, 2024
@boegel boegel added this to the release after 4.9.0 milestone Feb 27, 2024
@boegel boegel changed the title Correctly have is_dot_org as True when v >=11 and fix motorBike example for v >=11 fix OpenFOAM easyblock to correctly have is_dot_org as True when v >=11 and fix motorBike example for v >=11 Feb 28, 2024
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 11, 2024

@boegelbot please test @ generoso
EB_ARGS="OpenFOAM-11-foss-2023a.eb --sanity-check-only"

@boegelbot
Copy link
Copy Markdown

boegelbot commented Mar 11, 2024

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=3232 EB_ARGS="OpenFOAM-11-foss-2023a.eb --sanity-check-only" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3232 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13067

Test results coming soon (I hope)...

Details

- notification for comment with ID 1988503766 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

boegelbot commented Mar 11, 2024

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-11-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns4 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d47b7754c1e772ed07573692160c02d1 for a full test report.

boegel
boegel requested changes Mar 26, 2024
View reviewed changes
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
boegel
boegel requested changes Mar 26, 2024
View reviewed changes
Comment thread easybuild/easyblocks/o/openfoam.py Outdated
Neves-P and others added 3 commits March 26, 2024 09:51
@Neves-P @boegel
Recursively change permissions of test_dir
277a4ea 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@Neves-P @boegel
Consistently check version numbers
0d4dc2b 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@Neves-P @boegel
No need for changing the is_dot_org check
9e56c11 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 26, 2024 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2312-foss-2023a.eb
  • SUCCESS OpenFOAM-10-foss-2023a.eb
  • SUCCESS OpenFOAM-11-foss-2023a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3154.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/357b62d3b0a4786db7dbd17e4273c4c2 for a full test report.

edit: was using --sanity-check-only, and I checked that the sanity check is indeed being run when it's supposed to

boegel
boegel requested changes Mar 26, 2024
View reviewed changes
Comment thread easybuild/easyblocks/o/openfoam.py
@Neves-P @boegel
Check if motorBike tutorial is present
c4f252d 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@boegel boegel changed the title fix OpenFOAM easyblock to correctly have is_dot_org as True when v >=11 and fix motorBike example for v >=11 fix OpenFOAM easyblock to fix motorBike example in sanity check for v >=11 Mar 26, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 26, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2312-foss-2023a.eb
  • SUCCESS OpenFOAM-10-foss-2023a.eb
  • SUCCESS OpenFOAM-11-foss-2023a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3125.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b157d0d6bd4d088972ec543f4f587507 for a full test report.

@boegel boegel merged commit e987d3f into easybuilders:develop Mar 26, 2024
@Neves-P Neves-P deleted the openfoam branch March 26, 2024 16:42
@boegel boegel changed the title fix OpenFOAM easyblock to fix motorBike example in sanity check for v >=11 fix OpenFOAM easyblock to fix motorBike example in sanity check for versions >=11 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Neves-P @bedroge @boegelbot @boegel
⚡