set $CARGO_NET_OFFLINE to true in set_cargo_vars method of Cargo easyblock (only if offline mode is used), so it's set for every extension when CargoPythonBundle easyblock is used#3764
Merged
Micket merged 2 commits intoeasybuilders:developfrom Jun 7, 2025
Conversation
…go` easyblock, so it's set for every extension when `CargoPythonBundle` easyblock is used
Micket
requested changes
Jun 7, 2025
Co-authored-by: Mikael Öhman <micketeer@gmail.com>
boegel
changed the title
$CARGO_NET_OFFLINE to true in set_cargo_vars method of Cargo easyblock, so it's set for every extension when CargoPythonBundle easyblock is used$CARGO_NET_OFFLINE to true in set_cargo_vars method of Cargo easyblock (only if offline mode is used), so it's set for every extension when CargoPythonBundle easyblock is used
Member
Author
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)$CARGO_NET_OFFLINEused to be set for every extension being installed (sort of by accident), but that's no longer the case due to the changes in easybuilders/easybuild-framework#4868, so this fixes a regression (not forcingcargoto not download crates) introduced in EasyBuild v5.1.0