Skip to content

add back configure options for PETSc dependencies with generic --with options#3857

Merged
boegel merged 1 commit intoeasybuilders:developfrom
lexming:fix-petsc-mumps
Jul 31, 2025
Merged

add back configure options for PETSc dependencies with generic --with options#3857
boegel merged 1 commit intoeasybuilders:developfrom
lexming:fix-petsc-mumps

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jul 30, 2025

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 30, 2025

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.17.4-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node379.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.9.20
See https://gist.github.com/lexming/94842eced3fcef8d6d4c71ba180ee12e for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 30, 2025

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.20.3-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node380.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.9.20
See https://gist.github.com/lexming/5c7b0a77b5601190f8a75385b4357c44 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 31, 2025

easybuilders/easybuild-easyconfigs#23252 (comment) Do we also want to try to include this fix as well? We should not be using --CFLAGS --FFLAGS for any of the versions of PETSc we have.

        self.cfg.update('configopts', '--COPTFLAGS="%s"' % os.getenv('CFLAGS'))
        self.cfg.update('configopts', '--CXXOPTFLAGS="%s"' % cxxflags)
        self.cfg.update('configopts', '--FFOPTLAGS="%s"' % os.getenv('F90FLAGS'))

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2025

easybuilders/easybuild-easyconfigs#23252 (comment) Do we also want to try to include this fix as well? We should not be using --CFLAGS --FFLAGS for any of the versions of PETSc we have.

That's totally unrelated to the regression being fixed here, so let's make that a separate PR (I'm happy to look into that)

@boegel boegel changed the title reintroduce configopts in PETSc for dependencies with generic --with options add back configure options for PETSc dependencies with generic --with options Jul 31, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.22.5-foss-2023b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3544.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/579174cd869944dcec64c2c93dd91957 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 361eda3 into easybuilders:develop Jul 31, 2025
17 checks passed
@lexming lexming deleted the fix-petsc-mumps branch September 1, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants