Move setting of $PYTHON* environment variables to load_module method in Python easyblock#3958
Conversation
7a886d3 to
afb99b1
Compare
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
$PYTHON* environment variables to correct method in Python easyblock
boegel
left a comment
There was a problem hiding this comment.
lgtm
Makes sense, since load_module is called (through load_fake_module) in the fake_module_environment context manager that is used when installing extensions (in either EasyBlock.install_extensions_sequential or EasyBlock.install_extensions_parallel
|
@boegelbot please test @ jsc-zen3 |
$PYTHON* environment variables to correct method in Python easyblock$PYTHON* environment variables to load_module method in Python easyblock
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3432713354 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
(created using
eb --new-pr)Otherwise the sanity check might fail as it reloads the module for that