Skip to content

Move setting of $PYTHON* environment variables to load_module method in Python easyblock#3958

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20251014133801_new_pr_python
Oct 22, 2025
Merged

Move setting of $PYTHON* environment variables to load_module method in Python easyblock#3958
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20251014133801_new_pr_python

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Oct 14, 2025

(created using eb --new-pr)

Otherwise the sanity check might fail as it reloads the module for that

@Flamefire Flamefire force-pushed the 20251014133801_new_pr_python branch from 7a886d3 to afb99b1 Compare October 14, 2025 11:40
@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.18-GCCcore-12.3.0.eb

  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb

  • SUCCESS Python-3.13.1-GCCcore-14.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
c144 - Linux AlmaLinux 9.4, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 560.35.03, Python 3.9.18
See https://gist.github.com/Flamefire/2d69050aac7a27e4d69e148e1f33c98c for a full test report.

@boegel boegel changed the title Move setting of PYTHON variables to correct method in Python easyblock Move setting of $PYTHON* environment variables to correct method in Python easyblock Oct 22, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Makes sense, since load_module is called (through load_fake_module) in the fake_module_environment context manager that is used when installing extensions (in either EasyBlock.install_extensions_sequential or EasyBlock.install_extensions_parallel

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 22, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="Python-3.12.3-GCCcore-13.3.0.eb Python-bundle-PyPI-2024.06-GCCcore-13.3.0.eb matplotlib-3.9.2-gfbf-2024a.eb --installpath /tmp/$USER/pr3958"

@boegel boegel added the bug fix label Oct 22, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Oct 22, 2025
@boegel boegel changed the title Move setting of $PYTHON* environment variables to correct method in Python easyblock Move setting of $PYTHON* environment variables to load_module method in Python easyblock Oct 22, 2025
@boegelbot
Copy link
Copy Markdown

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3958 EB_ARGS="Python-3.12.3-GCCcore-13.3.0.eb Python-bundle-PyPI-2024.06-GCCcore-13.3.0.eb matplotlib-3.9.2-gfbf-2024a.eb --installpath /tmp/$USER/pr3958" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3958 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8526

Test results coming soon (I hope)...

Details

- notification for comment with ID 3432713354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.12.3-GCCcore-13.3.0.eb
  • SUCCESS Python-bundle-PyPI-2024.06-GCCcore-13.3.0.eb
  • SUCCESS matplotlib-3.9.2-gfbf-2024a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/12667977f94811d27954b6f7b9cc51d5 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 5bf4ceb into easybuilders:develop Oct 22, 2025
22 checks passed
@Flamefire Flamefire deleted the 20251014133801_new_pr_python branch October 23, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants