Add cleanup in easyblock of OpenFoam#780
Conversation
|
This requires retesting all OpenFOAM(-Extend) builds, so assigning 2.6.0 milestone on this... |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1526/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
ping on retesting? |
|
@wpoely86: reping... |
* develop: (162 commits) Check only for key jar files to remove complicated checking logic for different versions Move log message Overwrite MakeCp options for mutil Rework rename & cp in makecp Rework mutil block Bugfix for makecp Moved some jar file sanity checks. ensure list of Python lib dirs always has a 'lib/...' entry Extend version of makecp: add support for renaming Easyblock for mutil fix bug in copying back libraries for GATE 6.1 and earlier use a loop also define $LD in buildopts for GATE added @author lucamar (I don't want to be sued) added cuda support directly to cp2k.py easyblock added cuda support directly to cp2k.py easyblock cp2k cray support more style fixes in MPICH easyblock fix remarks admit that @besserox was right ...
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1791/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@besserox: thoughts on this? |
|
@wpoely86 Can you elaborate on why it is necessary to do this? Doesn't EasyBuild remove any previous install before building? |
|
OK. It should not hurt. Do you have a PR to remove these lines from the easyconfigs? |
|
There is now: easybuilders/easybuild-easyconfigs#2689 |
|
wcleanAll is indeed needed under certain situations. Like adding patches that adds new include files for instance. So yes, please include this. |
* origin/develop: (793 commits) bump version to v3.5.0dev bump version to 3.4.0 + minor edits in release notes avoid always including /usr/include to $CPATH in icc module prepare release notes for eb340 fix function signature for fetch_extension_sources in OCaml easyblock fix defining self.subdir in MCR easyblock minor style fixes + clearer commnents in MCR easyblock Adjust permissions for directories in suitesparse. Fixes easybuilders#1157. fix grabbing output of 'gcc -print-multiarch' enhance icc easyblock to inlude multipath include dir in $CPATH revert unintended/premature changes to icc.py fix specifying -DOPENGL_gl_LIBRARY for recent versions of ROOT strip off leading 'v' in ROOT version when comparing with a specific version number update ROOT easyblock to support recent versions that require using CMake, add sanity check, clean up/enhance make_module* fixing when sanity_check is not run and the subdirectory is not found more fixes to mcr.py Modified code to find the subdirectory so that it uses patterns. Also moved it to its own function so that it can be called in either the sanity_check_step or the make_module_extra step update MRtrix easyblock for 3.0 & beyond + use copy function reinstalling MCR with --module-only results in the wrong value for MCRROOT because it discovers the subdir only during the install step. This patch fixes this added a call to super post_install_step for cuda recipe. Otherwise postinstallcmds are ignored. ...
|
OK, lets gets is old PR merged then! We should clean up the easyconfigs too but it doesn't hurt to already merge this. In the worst case, the clean is done twice. |
|
Testing this with existing OpenFOAM easyconfigs... |
|
Checks out, no problems encountered when testing with existing |
|
So apparently my checking of this wasn't thorough enough, since It seems like Fix in #1258 |
5 participants
No description provided.