{bio}[foss/2020b] goatools v1.1.6 w/ Python 3.8.6#13364
{bio}[foss/2020b] goatools v1.1.6 w/ Python 3.8.6#13364verdurin merged 2 commits intoeasybuilders:developfrom
Conversation
|
Test report by @verdurin |
|
@boegelbot please test @ generoso |
|
@verdurin: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 875894631 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Going in, thanks @deniskristak! |
| {'source_urls': ['https://github.com/tanghaibao/goatools/archive/'], | ||
| 'filename': 'v%(version)s.tar.gz'}, | ||
| {'source_urls': ['http://geneontology.org/ontology/'], | ||
| 'filename': 'go-basic.obo', 'extract_cmd': 'cp %s %(builddir)s'}, |
There was a problem hiding this comment.
The installation of this easyconfig is already failing because go-basic.odo has changed, and hence the checksum validation fails.
It's probably not a good idea to include these files in the installation itself, there's no way to ensure that this keeps working.
It's fine to let the end user download these files before using this tool, no?
There was a problem hiding this comment.
oh, didn't expect that to happen...you are right i guess, but we can't perform the complex sanity check in that case
There was a problem hiding this comment.
We can, we just have to include the downloading of the necessary files in the sanity check itself (which is better than not doing a sanity check at all imho)
I'm working on that, will open a PR once it's fully working...
There was a problem hiding this comment.
thank you! ill cleanup&close then
4 participants
(created using
eb --new-pr)