Skip to content

add additional valid checksum for norm 1.0-9.5 extension in R 4.1.0 and 4.1.2 easyconfigs#14987

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20220212135920_new_pr_R410
Feb 15, 2022
Merged

add additional valid checksum for norm 1.0-9.5 extension in R 4.1.0 and 4.1.2 easyconfigs#14987
akesandgren merged 1 commit intoeasybuilders:developfrom
SebastianAchilles:20220212135920_new_pr_R410

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Feb 12, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2022

Again?!

@SebastianAchilles Did you diff the old vs new source tarball?

@boegel boegel modified the milestones: 4.x, next release (4.5.4?) Feb 12, 2022
@SebastianAchilles
Copy link
Copy Markdown
Member Author

Again?!

This time it is a different extension though. 😉

@SebastianAchilles Did you diff the old vs new source tarball?

There are no code changes, the only difference is the description and the MD5 file:

$ diff -ru norm_1.0-9.5_old norm_1.0-9.5
diff -ru norm_1.0-9.5_old/DESCRIPTION norm_1.0-9.5/DESCRIPTION
--- norm_1.0-9.5_old/DESCRIPTION        2013-03-01 14:30:31.000000000 +0100
+++ norm_1.0-9.5/DESCRIPTION    2022-02-09 15:35:29.000000000 +0100
@@ -17,3 +17,4 @@
 Packaged: 2013-02-27 19:16:19 UTC; rforge
 NeedsCompilation: yes
 License_restricts_use: no
+License_is_FOSS: yes
diff -ru norm_1.0-9.5_old/MD5 norm_1.0-9.5/MD5
--- norm_1.0-9.5_old/MD5        2013-03-01 14:30:31.000000000 +0100
+++ norm_1.0-9.5/MD5    2022-02-09 15:35:29.000000000 +0100
@@ -1,4 +1,4 @@
-66fded5989915184abb853d93a5f527f *DESCRIPTION
+384fddd8bb692a8332ba2d750d7b4a3a *DESCRIPTION
 d867862f44296b2c82a2bd967ad9455e *INDEX
 00586c4834941a13260ef2c23c1df3f6 *LICENSE
 4076ba3a74509a4ddec12c0ca583e1f2 *NAMESPACE

Therefore, it makes sense to keep accepting both the old and the new SHA256 checksum, since it doesn't really matter which source tarball you use.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

See also #14993

@akesandgren
Copy link
Copy Markdown
Contributor

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=14987 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14987 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8134

Test results coming soon (I hope)...

Details

- notification for comment with ID 1039095986 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a943055b9910be57eab45a188dd0b44a for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @SebastianAchilles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants