add and fix patches for PyTorch 1.9.0 on POWER#15919
add and fix patches for PyTorch 1.9.0 on POWER#15919boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Build now works although 2 tests fail on PPC: |
Micket
left a comment
There was a problem hiding this comment.
lgtm (mainly because i don't know any better) (I'll try to find a machine to run build report from)
|
Oops, missed that it was marked draft! |
|
Done now. Just noticed a mistake and wanted to wait for the custom test first. Started a job testing this on PPC now. |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Ok, this works now, the failing EC is PyTorch-1.9.0-fosscuda-2020b-imkl.eb as IMKL isn't available for PPC, so that is ok. |
|
Test report by @Flamefire |
|
One failing test for |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
I won't let the failing test_autograd test block this PR, since it also occurs without the changes in this PR.
@Flamefire Is this something worth following up on?
|
Going in, thanks @Flamefire! |
|
Yes, looks worth to double check at least: #16233 |
|
Test report by @Flamefire |
(created using
eb --new-pr)The patch introduced a C&P bug resulting in:
I.e.
bwas used instead ofexp.Although in the referenced PR I left that function untouched it seems to be required as without it the
test_binary_ufuncsfails but succeeds with it.Added a commit to make the change correct.