Skip to content

{cae}[foss/2022a] OpenFOAM v10#16259

Merged
boegel merged 3 commits intoeasybuilders:developfrom
kosl:20220919200239_new_pr_OpenFOAM10
Jan 3, 2023
Merged

{cae}[foss/2022a] OpenFOAM v10#16259
boegel merged 3 commits intoeasybuilders:developfrom
kosl:20220919200239_new_pr_OpenFOAM10

Conversation

@kosl
Copy link
Copy Markdown
Contributor

@kosl kosl commented Sep 19, 2022

(created using eb --new-pr)

@kosl
Copy link
Copy Markdown
Contributor Author

kosl commented Sep 19, 2022

Requires easybuilders/easybuild-easyblocks#2766 to be merged

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2022

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2766"
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16259 EB_ARGS="--include-easyblocks-from-pr 2766" /opt/software/slurm/bin/sbatch --job-name test_PR_16259 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9168

Test results coming soon (I hope)...

Details

- notification for comment with ID 1252334427 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2766
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b61256aa0452842e0d4fb555281f9c30 for a full test report.

@mboisson
Copy link
Copy Markdown
Contributor

@kosl, didn't you encounter this ? #15907

@mboisson
Copy link
Copy Markdown
Contributor

Also, OpenFOAM should not require foss, gompi is enough, nothing in its dependences or itself uses BLAS or FFTW as far as I know

@kosl
Copy link
Copy Markdown
Contributor Author

kosl commented Oct 28, 2022

@kosl, didn't you encounter this ? #15907
I have tried

ml OpenFOAM/10-foss-2022a
ompi_info | grep -i thread
          Thread support: posix (MPI_THREAD_MULTIPLE: yes, OPAL support: yes, OMPI progress: no, ORTE progress: yes, Event lib: yes)

source $FOAM_BASH
cp -a $FOAM_TUTORIALS openfoam-tutorials
./Allclean
./Allrun
grep ERROR log.*
paraFoam

I am getting correct results in my opinion and no problems in log.snappyHexMesh with runParallel snappyHexMesh -overwrite

Will rename to gompi toolchain.

@satishskamath
Copy link
Copy Markdown
Contributor

satishskamath commented Dec 14, 2022

@kosl Any updates on this PR?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2022

Also, OpenFOAM should not require foss, gompi is enough, nothing in its dependences or itself uses BLAS or FFTW as far as I know

ParaView dependency is built with foss, so OpenFOAM should be built with foss too

@satishskamath
Copy link
Copy Markdown
Contributor

satishskamath commented Dec 28, 2022

@kosl: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/3787873366 Output from first failing test suite run:

FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 955, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: No checksum issues:
Checksums missing for one or more sources/patches in OpenFOAM-10-foss-2022a.eb: found 1 sources + 1 patches vs 3 checksums

----------------------------------------------------------------------
Ran 16073 tests in 896.759s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01) Please talk to my owner @boegel if you notice you me acting stupid), or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

How come there are checksum errors? I tried it locally and it worked. @smoors

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2022

How come there are checksum errors? I tried it locally and it worked. @smoors

there is only 1 patch listed, but there are 3 checksums (1 for source, 2 for patches)

@satishskamath
Copy link
Copy Markdown
Contributor

satishskamath commented Jan 2, 2023

How come there are checksum errors? I tried it locally and it worked. @smoors

there is only 1 patch listed, but there are 3 checksums (1 for source, 2 for patches)

The # OpenFOAM-v1906-wmake-ompi.patch is not required.
@smoors or @boegel Can you make this change in the eb file?

@easybuilders easybuilders deleted a comment from boegelbot Jan 2, 2023
@easybuilders easybuilders deleted a comment from boegelbot Jan 2, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2023

How come there are checksum errors? I tried it locally and it worked. @smoors

there is only 1 patch listed, but there are 3 checksums (1 for source, 2 for patches)

The # OpenFOAM-v1906-wmake-ompi.patch is not required. @smoors or @boegel Can you make this change in the eb file?

yes, done in 3c671c2

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3130.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/91728d121230b655d777a1394fb6fe55 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.7.0) Jan 3, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 3, 2023

Going in, thanks @kosl!

@boegel boegel merged commit 953ac95 into easybuilders:develop Jan 3, 2023
@mboisson
Copy link
Copy Markdown
Contributor

mboisson commented Jan 4, 2023

Also, OpenFOAM should not require foss, gompi is enough, nothing in its dependences or itself uses BLAS or FFTW as far as I know

ParaView dependency is built with foss, so OpenFOAM should be built with foss too

ParaView does not require foss either, it does not need MKL/FFTW
https://github.com/ComputeCanada/easybuild-easyconfigs-installed-avx2/blob/main/2020/ParaView/ParaView-5.10.0-gompi-2020a.eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants