Skip to content

fix source URL for PCRE2#16987

Merged
smoors merged 1 commit intoeasybuilders:developfrom
crubb:20221221224519_new_pr_PCRE21021
Dec 22, 2022
Merged

fix source URL for PCRE2#16987
smoors merged 1 commit intoeasybuilders:developfrom
crubb:20221221224519_new_pr_PCRE21021

Conversation

@crubb
Copy link
Copy Markdown
Contributor

@crubb crubb commented Dec 21, 2022

(created using eb --new-pr)

@crubb crubb changed the title Updating download links to 'official home on GitHub' according to pcre.org Updating PCRE2 download links to 'official home on GitHub' according to pcre.org Dec 21, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

@crubb it's not very useful to update the very old easyconfigs.

let's remove everything older than GCCcore/8.3.0?

edit: we can just run the test on the download without actually building, so should be ok

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

@boegelbot: please test @ generoso EB_ARGS="--force-download --stop fetch"

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16987 EB_ARGS="--force-download --stop fetch" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16987 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9877

Test results coming soon (I hope)...

Details

- notification for comment with ID 1362620457 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 34 out of 34 (8 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/53776f3fb175778f5f6aab226fa6f889 for a full test report.

@smoors smoors added the bug fix label Dec 22, 2022
@smoors smoors added this to the next release (4.7.0) milestone Dec 22, 2022
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

Going in, thanks @crubb!

@smoors smoors merged commit b2473dd into easybuilders:develop Dec 22, 2022
@boegel boegel changed the title Updating PCRE2 download links to 'official home on GitHub' according to pcre.org fix source URL for PCRE2 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants