Skip to content

fix homepage in ELPA easyconfigs (due to switch to new domain)#17358

Merged
Micket merged 2 commits intoeasybuilders:developfrom
boegel:20230216105342_new_pr_ELPA201502002
Feb 26, 2023
Merged

fix homepage in ELPA easyconfigs (due to switch to new domain)#17358
Micket merged 2 commits intoeasybuilders:developfrom
boegel:20230216105342_new_pr_ELPA201502002

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 16, 2023

(created using eb --new-pr)

partial fix for #17162 (other part is in #17357 where also source URLs are fixed)

@boegel boegel added this to the next release (4.7.1?) milestone Feb 16, 2023
@boegel boegel added the bug fix label Feb 16, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/4192741432
Output from first failing test suite run:

FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 963, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: No checksum issues:
Checksums missing for one or more sources/patches in ELPA-2016.05.004-intel-2016b.eb: found 1 sources + 0 patches vs 0 checksums
Checksums missing for one or more sources/patches in ELPA-2016.05.004-intel-2017a.eb: found 1 sources + 1 patches vs 0 checksums

----------------------------------------------------------------------
Ran 16415 tests in 649.131s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 17, 2023

source_urls seems to be different as well nowdays?

https://elpa.mpcdf.mpg.de/software/tarball-archive/ELPA_TARBALL_ARCHIVE.html
suggests

https://elpa.mpcdf.mpg.de/software/tarball-archive/Releases/%(version)s/

edit: for the older ones i only i guess. the git release tags should also work for 2017.05.001 onwards

Comment thread easybuild/easyconfigs/e/ELPA/ELPA-2016.05.004-intel-2017a.eb
Comment thread easybuild/easyconfigs/e/ELPA/ELPA-2016.05.004-intel-2016b.eb
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2023

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-c2 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/e18988a793974a31b4f0e61b4c945d38 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2023

Going in, thanks @boegel!

@Micket Micket merged commit ceb39db into easybuilders:develop Feb 26, 2023
@boegel boegel deleted the 20230216105342_new_pr_ELPA201502002 branch February 26, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants