Skip to content

replace src include path with installation dir for HDF5 (intel)#17488

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
smoors:20230309201105_new_pr_HDF51140
Mar 10, 2023
Merged

replace src include path with installation dir for HDF5 (intel)#17488
jfgrimm merged 1 commit intoeasybuilders:developfrom
smoors:20230309201105_new_pr_HDF51140

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Mar 9, 2023

(created using eb --new-pr)

intel version of #17469

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Mar 10, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=17488 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17488 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10412

Test results coming soon (I hope)...

Details

- notification for comment with ID 1463445946 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/203b111757fa5aac15f88770216665d3 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4ed7f79c2eced5689ada00532af766ee for a full test report.

@jfgrimm jfgrimm added this to the next release (4.7.1) milestone Mar 10, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

@boegelbot: please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17488 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17488 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2304

Test results coming soon (I hope)...

Details

- notification for comment with ID 1463664432 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
himem04.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz (cascadelake), Python 3.6.8
See https://gist.github.com/f6499fced7ff8d326b4d56aabec391e0 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

Going in, thanks @smoors!

@jfgrimm jfgrimm merged commit 2fb2eda into easybuilders:develop Mar 10, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2709a9621b9667fcf896d55884331c5a for a full test report.

@hattom
Copy link
Copy Markdown
Contributor

hattom commented Mar 21, 2023

Should this regex go into the EasyBlock in future?
(Looking at the discussion on #17469, it's just a workaround for a bug, so is hopefully not permanent. I guess that answers my question)

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 21, 2023

@hattom I believe it should be getting fixed upstream (see HDFGroup/hdf5#2422)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants