Skip to content

consistently use ON/OFF for -DBUILD_SHARED_LIBS#18484

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:fix-cmake-constants
Sep 1, 2023
Merged

consistently use ON/OFF for -DBUILD_SHARED_LIBS#18484
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:fix-cmake-constants

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Aug 8, 2023

CMake defines options as uppercase:

True if the constant is 1, ON, YES, TRUE, Y, or a non-zero number
False if the constant is 0, OFF, NO, FALSE, N, IGNORE, NOTFOUND, the empty string, or ends in the suffix -NOTFOUND

Although it (now?) says "Named boolean constants are case-insensitive." this may not have always been the case.
So make all values for -DBUILD_SHARED_LIBS ON/OFF to be consistent.

@Flamefire
Fix spelling of BOOL values in CMake configopts
f1acbec 
CMake defines options as uppercase:
> True if the constant is 1, ON, YES, TRUE, Y, or a non-zero number
> False if the constant is 0, OFF, NO, FALSE, N, IGNORE, NOTFOUND, the empty string, or ends in the suffix -NOTFOUND

Although it (now?) says "Named boolean constants are case-insensitive."
this may not have always been the case.
So make all values for `-DBUILD_SHARED_LIBS`  ON/OFF to be consistent.
@Flamefire
Add checksum
bf493e0
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Aug 8, 2023 •
edited
Loading

Test report by @Flamefire (only non-Intel and > 2016a)
SUCCESS
Build succeeded for 21 out of 21 (21 easyconfigs in total)
taurusml5 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/Flamefire/669653ba8620e3968003fc6aa21fae37 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Aug 15, 2023
@boegel boegel added the bug fix label Aug 15, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 15, 2023
@boegel boegel changed the title Fix spelling of BOOL values in CMake configopts consistently use ON/OFF for -DBUILD_SHARED_LIBS Sep 1, 2023
boegel
boegel approved these changes Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 1, 2023

Test report by @boegel
SUCCESS
Build succeeded for 22 out of 22 (22 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/ed962a90dae9d7799372ddab79e52b2f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 1, 2023

Going in, thanks @Flamefire!

@boegel boegel merged commit 800cb09 into easybuilders:develop Sep 1, 2023
@Flamefire Flamefire deleted the fix-cmake-constants branch September 1, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel
⚡