Skip to content

{vis}[GCCcore/12.3.0] GTK3 v3.24.37, Wayland v1.22.0#18595

Merged
boegel merged 9 commits intoeasybuilders:developfrom
stefan-wolfsheimer:GTK3-3.24.37
Aug 31, 2023
Merged

{vis}[GCCcore/12.3.0] GTK3 v3.24.37, Wayland v1.22.0#18595
boegel merged 9 commits intoeasybuilders:developfrom
stefan-wolfsheimer:GTK3-3.24.37

Conversation

@stefan-wolfsheimer
Copy link
Copy Markdown
Contributor

@stefan-wolfsheimer stefan-wolfsheimer commented Aug 18, 2023

@stefan-wolfsheimer
Copy link
Copy Markdown
Contributor Author

The package builds on our system without the patch
adwaita-icon-theme-3.34.3_disable-svg-conversion.patch

I have adopted the patch to adwaita-icon-theme v44.0.
Does it build on other systems? Does it fail due to a SVG encoding error? Should I add the adopted patch to the PR?

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 22, 2023

@stefan-wolfsheimer #13449 gives more context on why the patch was added, does that help to clarify the need for it?

@boegel boegel changed the title {vis}[GCCcore/12.3.0] Gtk3 v3.24.37 Wayland v1.22.0 {vis}[GCCcore/12.3.0] GTK3 v3.24.37, Wayland v1.22.0 Aug 22, 2023
@stefan-wolfsheimer
Copy link
Copy Markdown
Contributor Author

@stefan-wolfsheimer #13449 gives more context on why the patch was added, does that help to clarify the need for it?

@boegel, thanks for the hint. It's a bit clearer. I added the patch to the PR.
Next time, I will follow the trace to PRs to get more information.

boegel
boegel previously approved these changes Aug 25, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 25, 2023

@boegelbot please test @ generoso
@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 25, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3118.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/4bca6c6fb75673b2e48400a7a7761b14 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18595 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18595 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11553

Test results coming soon (I hope)...

Details

- notification for comment with ID 1693590443 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c8215f72a7817432d53c5bf97f44843d for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
zen2-ubuntu-2304 - Linux Ubuntu 23.04 (Lunar Lobster), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.4
See https://gist.github.com/SebastianAchilles/3bd126935de36654b3a98e420db1fc3d for a full test report.

Comment thread easybuild/easyconfigs/g/GTK3/GTK3-3.24.37-GCCcore-12.3.0.eb
Co-authored-by: SebastianAchilles <s.achilles@fz-juelich.de>
@easybuilders easybuilders deleted a comment from boegelbot Aug 29, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2023

@boegelbot please test @ jsc-zen2

@easybuilders easybuilders deleted a comment from boegelbot Aug 29, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18595 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18595 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3266

Test results coming soon (I hope)...

Details

- notification for comment with ID 1697059318 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Copy Markdown
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
zen2-ubuntu-2304 - Linux Ubuntu 23.04 (Lunar Lobster), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.4
See https://gist.github.com/SebastianAchilles/cd73eff6f0dce7ed1be83ee0bd1b92c1 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 31, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18595 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18595 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3280

Test results coming soon (I hope)...

Details

- notification for comment with ID 1700461165 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel
boegel previously approved these changes Aug 31, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/7ff4979c8f8ccd7b798d77725b6df94a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 31, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3103.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/961654de2bb1cfa25827fd9425080fcc for a full test report.

@boegel boegel dismissed SebastianAchilles’s stale review August 31, 2023 07:19

requested change made

@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2023
@boegel boegel modified the milestones: 4.x, next release (4.8.1?) Aug 31, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 31, 2023

Going in, thanks @stefan-wolfsheimer!

@boegel boegel merged commit 916967d into easybuilders:develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants