You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extracted the test only from #18646 to check the file permissions of EC files on PR.
Test: ECs are readable, owner-writable and non-executable, i.e. at least 0644 without any executable flag.
An example failure I forced to test the test: AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be readable (owner, group, other), not executable, at least owner writable, is: 0o100511
Hm, I'd like to see what this looks like when it actually fails once, but i'm not sure how to trigger such a test locally
I added an example above: AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be readable (owner, group, other), not executable, at least owner writable, is: 0o100511
I.e. where 1 file fails all 3 checks. A single failure would then be e.g. AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be not executable, is: 0o100555
To trigger: GITHUB_EVENT_NAME=pull_request GITHUB_BASE_REF=develop python -m test.easyconfigs.suite -k test_ec_file_permissions after changing some EC file permissions in a commit
boegel
changed the title
Add test for EC file permissions
add test for easyconfig file permissions
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the test only from #18646 to check the file permissions of EC files on PR.
Test: ECs are readable, owner-writable and non-executable, i.e. at least 0644 without any executable flag.
An example failure I forced to test the test:
AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be readable (owner, group, other), not executable, at least owner writable, is: 0o100511