Skip to content

add test for easyconfig file permissions#18647

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:executable-ecs-test
Sep 4, 2023
Merged

add test for easyconfig file permissions#18647
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:executable-ecs-test

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Extracted the test only from #18646 to check the file permissions of EC files on PR.

Test: ECs are readable, owner-writable and non-executable, i.e. at least 0644 without any executable flag.

An example failure I forced to test the test:
AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be readable (owner, group, other), not executable, at least owner writable, is: 0o100511

@Micket Micket added this to the next release (4.8.1?) milestone Aug 28, 2023
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'd like to see what this looks like when it actually fails once, but i'm not sure how to trigger such a test locally

@Flamefire
Copy link
Copy Markdown
Contributor Author

Hm, I'd like to see what this looks like when it actually fails once, but i'm not sure how to trigger such a test locally

I added an example above:
AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be readable (owner, group, other), not executable, at least owner writable, is: 0o100511

I.e. where 1 file fails all 3 checks. A single failure would then be e.g. AssertionError: CFITSIO-3.34-ictce-5.5.0.eb must be not executable, is: 0o100555

To trigger: GITHUB_EVENT_NAME=pull_request GITHUB_BASE_REF=develop python -m test.easyconfigs.suite -k test_ec_file_permissions after changing some EC file permissions in a commit

@boegel boegel changed the title Add test for EC file permissions add test for easyconfig file permissions Aug 30, 2023
@boegel boegel added the tests label Aug 30, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 4, 2023

did a quick test, seems to work fine (although running a single test did not work for me, i had to run all of them).

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 8c6a7da into easybuilders:develop Sep 4, 2023
@Flamefire Flamefire deleted the executable-ecs-test branch September 5, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants