Skip to content

remove 'cstd': 'c++17' as this is default in GCC 11 for Abseil#18943

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231007110235_new_pr_Abseil202301252
Oct 7, 2023
Merged

remove 'cstd': 'c++17' as this is default in GCC 11 for Abseil#18943
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231007110235_new_pr_Abseil202301252

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 7, 2023

(created using eb --new-pr)

From https://gcc.gnu.org/projects/cxx-status.html#cxx17

C++17 mode is the default since GCC 11

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18943 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18943 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11883

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751670786 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ jsc-zen2

@branfosj branfosj added this to the next release (4.8.2?) milestone Oct 7, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/8e7013a6b65db6abdc4725984fcab500 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18943 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18943 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3500

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751671082 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/52a07f08168f324d8b47fc51289e1380 for a full test report.

@branfosj branfosj changed the title remove 'cstd': 'c++17' as this is default in GCC 11 for Abseil remove `'cstd': 'c++17' as this is default in GCC 11 for Abseil Oct 7, 2023
@branfosj branfosj changed the title remove `'cstd': 'c++17' as this is default in GCC 11 for Abseil remove 'cstd': 'c++17' as this is default in GCC 11 for Abseil Oct 7, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/dfe282d3701d04fe35515d1181a8b6ab for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 7, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit cadde22 into easybuilders:develop Oct 7, 2023
@branfosj branfosj deleted the 20231007110235_new_pr_Abseil202301252 branch October 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants