Skip to content

ensure right Python version is used in DP3, WSClean and dependencies by specifying -DPython3_EXECUTABLE CMake option#19119

Merged
casparvl merged 2 commits intoeasybuilders:developfrom
t1mk1k:ensure-casacore-python-dependency-is-used
Oct 31, 2023
Merged

ensure right Python version is used in DP3, WSClean and dependencies by specifying -DPython3_EXECUTABLE CMake option#19119
casparvl merged 2 commits intoeasybuilders:developfrom
t1mk1k:ensure-casacore-python-dependency-is-used

Conversation

@t1mk1k
Copy link
Copy Markdown

@t1mk1k t1mk1k commented Oct 31, 2023

CMake will pick up the newest Python version available instead of the Python version listed in the dependencies.
This issue was discovered while using the EESSI pipeline. For more information, see EESSI/software-layer#370 (comment) and https://gitlab.com/eessi/support/-/issues/17

@casparvl
Copy link
Copy Markdown
Contributor

@boegelbot please test @ generoso

@casparvl
Copy link
Copy Markdown
Contributor

To summarize: without this fix, the wrong (system) python is picked up by cmake in cases where the system python is newer than the one used in these EasyConfigs.

@boegelbot
Copy link
Copy Markdown
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19119 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19119 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12078

Test results coming soon (I hope)...

Details

- notification for comment with ID 1787008124 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19119 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19119 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3657

Test results coming soon (I hope)...

Details

- notification for comment with ID 1787012982 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/e43c9e6f92ca36534ef1c785fa0d553f for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c486eb282793afadaea3df5a132548cd for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/b38106ddeaebb48b3241ca2d96469860 for a full test report.

Comment thread easybuild/easyconfigs/a/AOFlagger/AOFlagger-3.4.0-foss-2022a.eb Outdated
@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/6e1e456e410af79ebecf7af2937e9f48 for a full test report.

Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the next release (4.9.0?) milestone Oct 31, 2023
@casparvl
Copy link
Copy Markdown
Contributor

Going in, thanks @t1mk1k!

@casparvl casparvl merged commit a8aca9a into easybuilders:develop Oct 31, 2023
@boegel boegel added the bug fix label Nov 8, 2023
@boegel boegel changed the title Ensure right Python version is used in DP3, WSClean and dependencies ensure right Python version is used in DP3, WSClean and dependencies by specifying -DPython3_EXECUTABLE CMake option Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants