Skip to content

fix build of Rust 1.70.0 by disabling download of pre-built LLVM#19264

Closed
boegel wants to merge 1 commit intoeasybuilders:developfrom
boegel:20231119152034_new_pr_Rust1700
Closed

fix build of Rust 1.70.0 by disabling download of pre-built LLVM#19264
boegel wants to merge 1 commit intoeasybuilders:developfrom
boegel:20231119152034_new_pr_Rust1700

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 19, 2023

(created using eb --new-pr)

fix for build failure of Rust-1.70.0-GCCcore-12.3.0.eb:

downloading https://ci-artifacts.rust-lang.org/rustc-builds/90c541806f23a127002de5b4038be731ba1458ca/
rust-dev-1.70.0-x86_64-unknown-linux-gnu.tar.xz
curl: (22) The requested URL returned error: 404

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:

    [llvm]
    download-ci-llvm = false

Build completed unsuccessfully in 0:05:22

This currently only seems to affect Rust 1.70.0, there's no such problem (currently) for older versions (like Rust-1.65.0-GCCcore-12.2.0.eb) and newer version (like Rust-1.73.0-GCCcore-13.2.0.eb).

@boegel boegel added the bug fix label Nov 19, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 19, 2023
@boegel boegel force-pushed the 20231119152034_new_pr_Rust1700 branch from 8113b3b to 32ee6bb Compare November 19, 2023 14:23
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 19, 2023

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19264 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19264 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12192

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817943437 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/37982d35d49f4e687954abf82e8fe450 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 19, 2023

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19264 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19264 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3759

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817969575 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/931beabcae62cfa3c0fd944683c38f53 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 19, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3144.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/73efb7c416f77c71df8a963c3e3e2a5a for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/6d0eb5ac11ec462f292081a467a831b1 for a full test report.

('OpenSSL', '1.1', '', SYSTEM),
]

prebuildopts = r"sed -i '/\[llvm\]/d' config.toml && "
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel could do with a comment explaining what's going on here?

@sassy-crick
Copy link
Copy Markdown
Collaborator

Test report by @sassy-crick
SUCCESS
Full report is here

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 23, 2023

See easybuilders/easybuild-easyblocks#3038 for a more elegant fix :)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2023

@lexming Makes sense to update the easyblock, this was more of a stop-gap solution since I wasn't sure whether older Rust versions were going to be a problem (looks like that's a no).

I'll close this, people can still use eb --from-pr 19264 to work around this issue until the next EasyBuild release (most likely v4.9.0) that includes easybuilders/easybuild-easyblocks#3038 is out .

@boegel boegel closed this Nov 24, 2023
@boegel boegel deleted the 20231119152034_new_pr_Rust1700 branch November 24, 2023 07:29
@boegel boegel restored the 20231119152034_new_pr_Rust1700 branch November 24, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants