Skip to content

prevent configure script of recent BLAST+ versions from prepending system paths to $PATH#20751

Merged
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:blast+_configure_fix
Jun 8, 2024
Merged

prevent configure script of recent BLAST+ versions from prepending system paths to $PATH#20751
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:blast+_configure_fix

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented Jun 6, 2024

@TopRichard found that when RPATH support is enabled BLAST+ fails on some systems (mostly on distros with more recent GCC versions, it seems) due to:

WARNING No '(RPATH)' found in 'readelf -d' output for /path/to/BLAST+/2.14.1-gompi-2023a/bin/run_with_lock

Only this executable was using RUNPATH instead of RPATH, all the other ones in the installation did have RPATH. This executable actually gets compiled at the end of the configure script, and it turned out that it's using the system GCC compiler (and using --enable-new-dtags). By debugging it a bit more and replacing my system compiler by a bash script that spits out some more information, I found that $PATH was actually changed, and this lead me to the following line src/build-system/configure:

PATH="$HOME/bin:/bin:/usr/bin:\$PATH"

By commenting that line, it now picks up the right compiler (or actually the RPATH wrappers, assuming RPATH support enabled), and it gets compiled with the proper flags. The RPATH wrappers make sure that --enable-new-dtags is changed into --disable-new-dtags, which ensures that RPATH instead of RUNPATH is used.

@bedroge bedroge added bug fix EESSI Related to EESSI project labels Jun 6, 2024
@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Jun 6, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=20751 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20751 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13652

Test results coming soon (I hope)...

Details

- notification for comment with ID 2152667233 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Jun 6, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/230bba993f7a39c39c628d9b717e40ec for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Jun 6, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen2), Python 3.6.8
See https://gist.github.com/bedroge/1407a2a89c7d6b24661b4687fa4813e4 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Jun 6, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20751 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20751 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4303

Test results coming soon (I hope)...

Details

- notification for comment with ID 2153015137 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3ce99aef29b602d8f18da5193b089ee4 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/7ea44e1a1be1bb8e285904b4cc311720 for a full test report.

@boegel boegel added this to the 4.9.2 milestone Jun 8, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (3 easyconfigs in total)
node3117.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/adf85854ba2659756cd2a6ebbb57948d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Going in, thanks @bedroge!

@boegel boegel merged commit 5d82167 into easybuilders:develop Jun 8, 2024
@bedroge bedroge deleted the blast+_configure_fix branch June 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants