Skip to content

add patch to fix build of pdsh 2.34 with Slurm 23.x#20795

Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:20240610194037_new_pr_pdsh234
Jun 10, 2024
Merged

add patch to fix build of pdsh 2.34 with Slurm 23.x#20795
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:20240610194037_new_pr_pdsh234

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 10, 2024

(created using eb --new-pr)

fix for:

In file included from slurm.c:53:
/usr/include/slurm/slurm.h:1393:31: error: unknown type name list_t; did you mean List?
 1393 | extern void slurm_list_append(list_t *l, void *x);
      |                               ^~~~~~
      |                               List

@boegel boegel added the bug fix label Jun 10, 2024
@boegel boegel added this to the 4.9.2 milestone Jun 10, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 10, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20795 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20795 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13707

Test results coming soon (I hope)...

Details

- notification for comment with ID 2158946659 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e5089a73230bb491296f45dac387dd7a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20795 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20795 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4357

Test results coming soon (I hope)...

Details

- notification for comment with ID 2159077993 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/79162ab764cedf98bc649aae05807c00 for a full test report.

Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 389f1f9 into easybuilders:develop Jun 10, 2024
@boegel boegel deleted the 20240610194037_new_pr_pdsh234 branch June 10, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants