Skip to content

promote pybind11 to runtime dependency for CPPE (to fix pip check failure)#21564

Merged
Micket merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20241006143833_new_pr_CPPE031
Dec 18, 2024
Merged

promote pybind11 to runtime dependency for CPPE (to fix pip check failure)#21564
Micket merged 1 commit intoeasybuilders:5.0.xfrom
boegel:20241006143833_new_pr_CPPE031

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 6, 2024

(created using eb --new-pr)

@boegel boegel added this to the 5.0 milestone Oct 6, 2024
@boegel boegel added bug fix EasyBuild-5.0 EasyBuild 5.0 labels Oct 6, 2024
@boegel boegel changed the title promote pybind11 to runtime dependency for CPPE (to fix 'pip check' failure) promote pybind11 to runtime dependency for CPPE (to fix pip check failure) Oct 6, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 6, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=21564 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_21564 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5012

Test results coming soon (I hope)...

Details

- notification for comment with ID 2395531129 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/3638061701bacc1a774b33dcd302ad6a for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Oct 6, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 9, 2024

Need to check whether this could fallout, and whether pybind11 really is a runtime dependency, or if it's just faulty packaging...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 16, 2024

Asked upstream to make sure: maxscheurer/cppe#47

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 6, 2024

The build system got overhauled since the 0.3.1 release (which is from 2020). See:
maxscheurer/cppe@1d2d0be

We could probably just move to using 0.3.3a instead?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 6, 2024

Requiring pybind11 as a runtime dependency is most likely a packaging mistake, but promoting it to a runtime dependency should have no real downsides (especially since we currently have pybind11 (incorrectly) as a runtime dependency of SciPy-bundle already), so I'm in favor of just merging this since it fixes a real problem that people will hit when installing these CPPE easyconfigs with EasyBuild 5.0, where pip check fails unless pybind11 is a runtime dependency.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 6, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21564 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21564 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14636

Test results coming soon (I hope)...

Details

- notification for comment with ID 2460006328 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 12, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21564 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21564 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14693

Test results coming soon (I hope)...

Details

- notification for comment with ID 2470548187 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2024

Testing this on generoso doesn't work because of the 5.0.x target branch:

ERROR: Framework (4.9.5.dev0-rd700144108b3a5508659a4d957c7594d35033e62) is a different major version than used in easybuilders/easybuild-easyconfigs PR #21564 (5.0.0.dev0)

@jfgrimm With that, I think we can merge this...

@boegel boegel requested a review from jfgrimm December 11, 2024 15:42
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (reluctantly, as this actually really isn't a builddep and it's just the devs that made a mistakes in their old build scripts)

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 15, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/cce62e8e2ac10be93f03332192e9db82 for a full test report.

@Micket Micket merged commit 58cc970 into easybuilders:5.0.x Dec 18, 2024
@boegel boegel deleted the 20241006143833_new_pr_CPPE031 branch December 18, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants