detect use of deprecated behavior in test runs#21885
Merged
branfosj merged 1 commit intoeasybuilders:5.0.xfrom Nov 23, 2024
Merged
detect use of deprecated behavior in test runs#21885branfosj merged 1 commit intoeasybuilders:5.0.xfrom
branfosj merged 1 commit intoeasybuilders:5.0.xfrom
Conversation
Re-enable the option to error on any deprecated behavior.
Flamefire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable the option to error on any deprecated behavior.
This is more general than the test case added in 93ed7fe checking (only) for use of deprecated EC parameters.
I'm not fully sure which one we want:
test_pr_deprecated_ec_paramscatches only deprecated EC params in changed easyconfigs$EASYBUILD_DEPRECATEDcatches any use of deprecated behaviorThe advantage of the test method is that it reports failures for all (changed) ECs in a single error while $EASYBUILD_DEPRECATED would error and stop on the first failure. We can also be more specific in what kind of deprecated behavior we want to check for if we don't use the variable, e.g. just the EC params in changed ECs, not also in dependencies. But then I don't see how we could easily detect e.g. usage of functions deprecated in the framework.
In any case, we should either merge this PR or remove the commented line.