Skip to content

Ensure Proteinortho links against FlexiBLAS, and bump to foss#22754

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
jfgrimm:fix-proteinortho-lapack
Apr 11, 2025
Merged

Ensure Proteinortho links against FlexiBLAS, and bump to foss#22754
branfosj merged 1 commit intoeasybuilders:developfrom
jfgrimm:fix-proteinortho-lapack

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Apr 11, 2025

Current easyconfigs missed the BLAS/LAPACK dependency. This didn't result in build failures, because the sources bundle their own lapack and pre-compiled artefacts, which are used as a fallback.

To see the difference, run an ldd on e.g. bin/proteinortho_clustering before/after the PR

Run 'make clean' before building, to ensure we don't use the bundled artefacts
Ensure flexiblas is linked
@jfgrimm jfgrimm added this to the release after 5.0.0 milestone Apr 11, 2025
@jfgrimm jfgrimm requested a review from branfosj April 11, 2025 09:51
@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Apr 11, 2025

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node097.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/3212faff182237bcfa562f9e420ca238 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22754 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22754 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6160

Test results coming soon (I hope)...

Details

- notification for comment with ID 2796471480 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/46add5dc38c7a6299883e7125cf598cd for a full test report.

@branfosj
Copy link
Copy Markdown
Member

Test report by @branfosj
SUCCESS
Build succeeded for 7 out of 7 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/fd3b8eb3fab755209d52b2cee2064e00 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

Going in, thanks @jfgrimm!

@branfosj branfosj merged commit 1c12134 into easybuilders:develop Apr 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants