new OpenFOAM-1612, OpenFOAM-1706 versions by olesenm · Pull Request #4814 · easybuilders/easybuild-easyconfigs

olesenm · 2017-07-05T12:30:41Z

edit: requires ~~easybuilders/easybuild-easyblocks#1205~~

olesenm · 2017-07-11T10:39:28Z

Now adjusted package names too.

olesenm · 2017-07-11T10:49:15Z

Hello @easybuilders/easybuild-easyconfigs-maintainers - review requested

wpoely86 · 2017-07-11T14:12:40Z

please explain?

I experienced an issue where the LD_LIBRARY_PATH pointed to the easybuild libreadline, which provoked symbol conflicts for my bash.

Can you elaborate on that a bit, exact error messages, etc.?

These dependencies should not be commented out, since otherwise we're at the mercy of whatever the OS provides (or doesn't), which is something we're trying to avoid.

wpoely86 · 2017-07-11T14:13:48Z

it's good practice to claim authorship of the patches and explain what they are supposed to do.

Where do the explanations go? I've seen some patches with # comments, but this seems to be fairly non-standard.

see my comment in the other patch

wpoely86 · 2017-07-11T14:14:37Z

any reason why you add them for both 2016a and 2016b? Is there any difference?

Honestly, I have no idea. I'm very new to easybuild but I understood that the configs need to specify a toolchain. The 2016b toolchang uses updated gcc etc.

There's little point in providing easyconfigs for an older toolchain like foss/2016a imho.

If people really need to install OpenFOAM with it, they can use --try-toolchain.

Generally speaking, it's better to stick to more recent toolchains, so I'd prefer just having easyconfigs for foss/2016b here.

olesenm · 2017-08-09T13:11:55Z

What is still needed to get this restarted? @easybuilders/easybuild-easyconfigs-maintainers @easybuild-easyconfigs-maintainers

boegel · 2017-08-10T13:45:33Z

please include a brief description of the patch above this line and mention the author

any lines above this line are comments

boegel · 2017-08-10T13:46:15Z

see my comment in the other patch

boegel · 2017-08-10T13:47:32Z

There's little point in providing easyconfigs for an older toolchain like foss/2016a imho.

If people really need to install OpenFOAM with it, they can use --try-toolchain.

Generally speaking, it's better to stick to more recent toolchains, so I'd prefer just having easyconfigs for foss/2016b here.

boegel · 2017-08-10T13:49:21Z

Can you elaborate on that a bit, exact error messages, etc.?

These dependencies should not be commented out, since otherwise we're at the mercy of whatever the OS provides (or doesn't), which is something we're trying to avoid.

boegel · 2017-08-10T13:50:06Z

please use SHA256 checksums (see also #5005)

boegel · 2017-08-10T13:50:59Z

We usually install OpenFOAM with CGAL & ParaView included as dependencies, so I'd prefer to stick to that.

What's the problem with the extra (indirect) Python dependency?

If I just want OpenFOAM, why a huge slew of python things? With paraview it would likely be good to distinguish between an off-screen and hardware mode too. However, I didn't want to get into this. All I wanted was to get a new version of OpenFOAM building with easybuild.

It's OK if you're not up for looking into this, it's just that our previous OpenFOAM easyconfigs do include CGAL & ParaView, so this is going to surprise people potentially...

boegel · 2017-08-10T13:52:18Z

style nitpicking: let's just make this a single line? I don't see the need to spread this over 4 lines...

source_urls = [('https://sourceforge.net/projects/openfoamplus/files/%(version)s', 'download')]

OK. On spack they run flake8 tests that complain when lines exceed 80 chars.

We have automated style checks in place too now, but allow lines up to 120 chars; too much silly splits (like this), we're not in the 80s anymore so 120 chars makes more sense imho ;)

boegel · 2017-08-10T13:52:56Z

shouldn't this be bumped to a more recent version of Boost (e.g. 1.64.0)?

boegel · 2017-08-10T13:53:36Z

this can be bumped to 3.8.2, there's an easyconfig available already for it

boegel · 2017-08-10T13:53:51Z

this can be bumped to 2.6.4

probably a holdover from before. I think that 2.6.1-2.6.3 were broken (weird namespaces if I remember).

OK, but I haven't seen any issues with 2.6.4 as far as I can recall, so let's bump it?

akesandgren · 2017-08-28T15:20:19Z

There is a bit of problem with OpenFOAM since there are (at least) 2 different distributions, openfoam.com and openfoam.org. And the version numbering differs.

Does anyone have any good insights on this subject?

Will the easyblock work correctly with both distributions?

boegel · 2017-09-06T21:29:19Z

@akesandgren Some updates are done in easybuilders/easybuild-easyblocks#1205, but for now it seems like the OpenFOAM easyblock is able to copy with both flavours (+ OpenFOAM-Extend as well)...

boegel · 2017-10-17T12:36:04Z

@olesenm Are you up for following up on this, or do you prefer that we take it from here?

olesenm · 2017-10-18T21:58:18Z

I'm fine with whatever works best for you (ie, please take over if possible). In a longer term I think that the various flavour/fork check should really only been done once, but that is just a style issue. At least for openfoam, I think that the changes to its config files would be better to do directly (if possible) rather that using patching to modify things. I've used this with reasonably good success in spack. When building openfoam-1706 with spack, I only use patch to adjust two entries in a single file and the rest of the configuration is simply emitted directly.

olesenm · 2017-12-11T22:28:41Z

I've picked this up again (would be nice to get it past the line before the 1712 release). However, I'm currently going crazy with all sorts of foss-2016b checksum errors. The tarfiles in question (Autoconf, libtool, M4, numactl) all have sha256sums that match what their easybuild files require, but I always get errors. Must be some flags somewhere I guess.

boegel · 2017-12-12T18:03:23Z

@olesenm Can you share which exact errors you are getting, and how you're triggering them? Can you also share your EasyBuild configuration (output of eb --show-config should suffice).

olesenm · 2017-12-13T07:52:00Z

Here is a rebuild log of one of the offenders (m4):
easybuild-oIFDJq.log

A manual verification of the check sums from the command line

checksum	result
md5sum	a5e9954b1dae036762f7b13673a2cf76 /home/mol/.local/easybuild/sources/m/M4/m4-1.4.17.tar.gz
sha256sum	3ce725133ee552b8b4baca7837fb772940b25e81b2a9dc92537aeaf733538c9e /home/mol/.local/easybuild/sources/m/M4/m4-1.4.17.tar.gz

So the sha256sum looks correct, but it would appear that verify_checksum still doesn't like it.

The easybuild config (eb --show-config):

#
# Current EasyBuild configuration
# (C: command line argument, D: default value, E: environment variable, F: configuration file)
#
buildpath      (D) = /home/mol/.local/easybuild/build
installpath    (D) = /home/mol/.local/easybuild
module-syntax  (E) = Tcl
modules-tool   (E) = EnvironmentModulesC
repositorypath (D) = /home/mol/.local/easybuild/ebfiles_repo
robot-paths    (D) = /home/mol/Software/easybuild/easybuild-easyconfigs/easybuild/easyconfigs
sourcepath     (D) = /home/mol/.local/easybuild/sources

The easyconfig is develop at 4a61927
The easyblocks is develop at 96efeb6eda2fd6c1abcdb596fdcc75d833ab5c4e.

boegelbot · 2017-12-13T08:53:16Z

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/315762446

Only showing partial log for 1st failed test suite run 7180.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762449

...
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 4

----------------------------------------------------------------------
Ran 8106 tests in 406.462s

FAILED (failures=1)
ERROR: Not all tests were successful.

7180.2 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762450
7180.3 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762451
7180.4 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762452
7180.5 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762453
7180.6 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762454
7180.7 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762455
7180.8 - errored => https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/315762456

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

boegel · 2018-02-24T14:21:42Z

@olesenm Is this still relevant now that #5781 is merged which adds easyconfigs for OpenFOAM v1712?

olesenm · 2018-02-28T13:50:48Z

I think that this content has probably been merged, so I'll close it and see it that is true.

boegel · 2018-02-28T13:58:25Z

@olesenm We have only merged easyconfigs for OpenFOAM v1712, not for the older versions you were adding here, but that's good enough going forward?

olesenm · 2018-02-28T23:12:48Z

Sounds good to me.

olesenm force-pushed the openfoam-com branch 4 times, most recently from 85929a0 to 9878cee Compare July 11, 2017 10:38

wpoely86 added this to the 3.4.0 milestone Jul 11, 2017

wpoely86 reviewed Jul 11, 2017

View reviewed changes

boegel requested changes Aug 10, 2017

View reviewed changes

boegel modified the milestones: 3.5.0, 3.4.0 Sep 6, 2017

easybuilders deleted a comment from boegelbot Sep 6, 2017

boegel mentioned this pull request Oct 19, 2017

remove foamExec & wdot from sanity checks, add blockMesh & checkMesh + enable logging for recent OpenFOAM versions easybuilders/easybuild-easyblocks#1272

Merged

boegel modified the milestones: 3.5.0, next release Dec 6, 2017

olesenm force-pushed the openfoam-com branch 2 times, most recently from 7f43b2c to ec7ea90 Compare December 13, 2017 08:00

OpenFOAM 1706 version (www.openfoam.com)

ee472f7

olesenm force-pushed the openfoam-com branch from ec7ea90 to ee472f7 Compare December 13, 2017 08:13

boegel removed this from the 3.5.1 milestone Jan 11, 2018

boegel added this to the 3.6.0 milestone Jan 11, 2018

easybuilders deleted a comment from boegelbot Jan 26, 2018

boegel modified the milestones: 3.5.2, 3.x Feb 24, 2018

olesenm closed this Feb 28, 2018

Conversation

olesenm commented Jul 5, 2017 • edited by boegel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olesenm commented Jul 11, 2017

Uh oh!

olesenm commented Jul 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olesenm Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olesenm commented Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akesandgren commented Aug 28, 2017

Uh oh!

boegel commented Sep 6, 2017

Uh oh!

boegel commented Oct 17, 2017

Uh oh!

olesenm commented Oct 18, 2017

Uh oh!

olesenm commented Dec 11, 2017

Uh oh!

boegel commented Dec 12, 2017

Uh oh!

olesenm commented Dec 13, 2017

Uh oh!

boegelbot commented Dec 13, 2017

Uh oh!

boegel commented Feb 24, 2018

olesenm commented Jul 5, 2017 •

edited by boegel

Loading

olesenm Jul 12, 2017 •

edited

Loading

olesenm commented Aug 9, 2017 •

edited

Loading