{lang}[GCCcore/6.4.0] Cython v0.26#4966
Conversation
|
Was PR #4923 |
|
Test report by @verdurin |
|
Test report by @verdurin |
|
Merging, thanks @JackPerdue |
| pyver = '2.7.13' | ||
| pyshortver = '2.7' | ||
| pysubver = '-bare' | ||
| versionsuffix = '-Python-%s%s' % (pyver, pysubver) |
There was a problem hiding this comment.
including -Python-<version> in the versionsuffix is meant to indicate that Python is pulled in as a runtime dependency
That's not the case here (it's only a build dep), but it should be since Cython can't be used without having (the right) Python around?
@JackPerdue Can you clarify your intentions here?
I suspect the %(pyver)s and %(pyshortver)s templates didn't work when Python is included as a build dep?
There was a problem hiding this comment.
Correct... the templates don't work when it is a builddep.
The point here is avoid building Cython for every toolchain option. e.g. for Python-2.7.13I don't want/need three different versions (intel/iomkl/foss) when one will do. Same for 3.6.2.
I need different ones for 2.7 and 3.6 so that when PythonPackage bite-compiles the .py (to create .pyc) files it uses the right Python and sets PYTHONPATH appropriately.
Python has to be a build dep at this stage (Cython is only a library and serves no real purpose on its one), since it will be later used by something that has the full-blown Python (with MPI/MKL). That is, unless you have some way to make the GCCcore-bare version not conflict with the full-blown version (which you don't).
There was a problem hiding this comment.
What you are basically doing is dancing around the fact that you're not including Python as a runtime dependency, while it actually is a runtime dependency? To me (currently), that's a sign that this may be the wrong approach.
There was a problem hiding this comment.
Not dancing around it at all. '-bare' indicates that it doesn't include the Python needed later. That it, it indicates that this isn't a standalone module but must be paired with a full Python. If you prefer '-build' to '-bare' we can do that. But the Python version has to be specified (I can't use the 2.7 Cython with 3.6)..
|
See PR #4962 which is probably where we need to discuss this (versus splitting among PRs). |
3 participants
(created using
eb --new-pr)