Avoid hardcoding `/bin/bash`

[ocaisa]

There are a few cases (including the eb wrapper itself) where we hardcode the use of /bin/bash. There are some cases (like EESSI) where this is not ideal and it's better to ask the environment where to find bash.

[ocaisa]

There are perhaps even some indications in an EESSI issue that this leads to problems.

[boegel]

/bin/bash is hardcoded in:

• eb wrapper script
• in run_shell_cmd
• in RPATH wrapper script (easybuild/scripts/rpath_wrapper_template.sh.in)

We should use /usr/bin/env bash instead, or resolve path to bash (in run_shell_cmd)

[bedroge]

There are perhaps even some indications in an EESSI issue that this leads to problems.

We're indeed seeing issues with at-spi2-core in EESSI now, and one of the reasons is that the EB RPATH wrappers have a /bin/bash shebang (and because LD_LIBRARY_PATH is being set to some Gentoo Prefix directories, this doesn't work).

[boegel]

@ocaisa I guess we can close this now #4441 is merged?

[ocaisa]

Yup