Skip to content

improve trace output for executed commands + drop requirement for --experimental for --trace#2306

Merged
wpoely86 merged 6 commits intoeasybuilders:developfrom
boegel:improve_trace
Sep 19, 2017
Merged

improve trace output for executed commands + drop requirement for --experimental for --trace#2306
wpoely86 merged 6 commits intoeasybuilders:developfrom
boegel:improve_trace

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 15, 2017

Example output with EasyBuild v3.4.0:

== configuring...
  >> running command './configure --prefix=/Users/kehoste/.local/easybuild/software/zlib/1.2.11' (output in /tmp/eb-508__5/easybuild-run_cmd-GQnYWm.log) [started at: 2017-09-15 20:58:04]
== building...
  >> running command 'make -j 4 CFLAGS="-O2 -fPIC"' (output in /tmp/eb-508__5/easybuild-run_cmd-NXCfvW.log) [started at: 2017-09-15 20:58:05]

Example output with this patch included:

== configuring...
  >> running command:
	[started at: 2017-09-15 20:56:14]
	[output logged in /tmp/eb-c13cXN/easybuild-run_cmd-pV_hJa.log]
	./configure --prefix=/Users/kehoste/.local/easybuild/software/zlib/1.2.11
  >> command completed: exit 0, ran in 1s
== building...
  >> running command:
	[started at: 2017-09-15 20:56:15]
	[output logged in /tmp/eb-c13cXN/easybuild-run_cmd-i0AnOq.log]
	make -j 4 CFLAGS="-O2 -fPIC"
  >> command completed: exit 0, ran in 3s

@boegel boegel added this to the 3.4.1 milestone Sep 15, 2017
@easybuilders easybuilders deleted a comment from boegelbot Sep 15, 2017
Comment thread easybuild/tools/build_log.py Outdated
tot_time = datetime.now() - start_time
if tot_time.seconds > 0:
hours, mins, secs = 0, 0, tot_time.seconds
if secs >= 60:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be done better I hope? Take total_seconds, use it as timestamp input and use the buildin formatting functions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, but apparently this doesn't work with Python 2.6... :(

AttributeError: 'datetime.timedelta' object has no attribute 'total_seconds'

@easybuilders easybuilders deleted a comment from boegelbot Sep 18, 2017
@easybuilders easybuilders deleted a comment from boegelbot Sep 18, 2017
@wpoely86 wpoely86 merged commit ee821bc into easybuilders:develop Sep 19, 2017
@boegel boegel deleted the improve_trace branch September 19, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants