deprecate running EasyBuild with Python 2.6 via new check_python_version() function#3076
Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom Nov 12, 2019
Merged
deprecate running EasyBuild with Python 2.6 via new check_python_version() function#3076wpoely86 merged 3 commits intoeasybuilders:developfrom
wpoely86 merged 3 commits intoeasybuilders:developfrom
Conversation
wpoely86
approved these changes
Nov 12, 2019
This was referenced Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change included, a deprecation warning will be printed when EasyBuild is run on top of Python 2.6:
Currently the main motivation here is to (slightly) trim down on test configurations in Travis CI, but longer term some code cleanup can be done when we've dropped support for Python 2.6.
In addition to deprecating support for Python 2.6, we also check whether the Python version being used is actually supported via the added
check_python_versionfunction.Up until now, we were only checking the Python version in the
ebwrapper, so no Python version check was done at all when EasyBuild is being used as a library...