Skip to content

Fix inconsistent module path usage that leads to repeated reloading in HMNS#3099

Merged
migueldiascosta merged 3 commits intoeasybuilders:developfrom
Micket:consistent_module_paths
Nov 26, 2019
Merged

Fix inconsistent module path usage that leads to repeated reloading in HMNS#3099
migueldiascosta merged 3 commits intoeasybuilders:developfrom
Micket:consistent_module_paths

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Nov 25, 2019 •
edited by boegel
Loading

fixes #3084, fixes #2226

@Micket Micket added the bug fix label Nov 25, 2019
@Micket Micket added this to the 4.1.0 milestone Nov 25, 2019
This was referenced Nov 25, 2019
Merged
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 25, 2019

Since this is a quite an elusive bug (see #2226...), it's worth the effort to get this covered in the tests.

The tests added in Micket#1 catch the issue, without the fix I get the following failure for test_check_module_path_hmns:

ERROR: test_check_module_path_hmns (__main__.ModulesTest)
Test behaviour of check_module_path with HierarchicalMNS.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/work/easybuild-framework/test/framework/modules.py", line 380, in test_check_module_path_hmns
    modtool.check_module_path()
  File "easybuild/tools/modules.py", line 449, in check_module_path
    self.prepend_module_path(mod_path)
  File "/Volumes/work/easybuild-framework/test/framework/modules.py", line 375, in broken_prepend_module_path
    raise EasyBuildError("broken prepend_module_path")
EasyBuildError: 'broken prepend_module_path'

Please review/merge so we can this one in for EasyBuild v4.1.0...

@Micket
Merge pull request #1 from boegel/consistent_module_paths
f4dc3a0 
add tests for curr_module_paths + check_module_path
migueldiascosta
migueldiascosta approved these changes Nov 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Nov 26, 2019

Going in, thanks @Micket!

@migueldiascosta migueldiascosta merged commit 6e77604 into easybuilders:develop Nov 26, 2019
@Micket Micket deleted the consistent_module_paths branch March 19, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

prepend_module_path is very slow long MODULEPATH drastically reduces performance

3 participants

@Micket @boegel @migueldiascosta
⚡