Skip to content

fix combination of --copy-ec and --from-pr#3482

Merged
ocaisa merged 52 commits intoeasybuilders:developfrom
boegel:copy-ec-from-pr
Nov 30, 2020
Merged

fix combination of --copy-ec and --from-pr#3482
ocaisa merged 52 commits intoeasybuilders:developfrom
boegel:copy-ec-from-pr

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 25, 2020

This continues from the work done by @ocaisa in #3473, and fixes the combination of --copy-ec and --from-pr.

The scope of this PR is pretty big, and I feel it should be split up into several PRs, so I made this a draft PR for now.

High level overview of additional changes:

fixes #3178

@boegel boegel added the bug fix label Oct 25, 2020
@boegel boegel added this to the 4.x milestone Oct 25, 2020
@boegel boegel modified the milestones: 4.x, 4.3.2 Oct 25, 2020
@boegel boegel changed the title fix combination of --copy-eb and --from-pr fix combination of --copy-ec and --from-pr Nov 25, 2020
@easybuilders easybuilders deleted a comment from boegelbot Nov 26, 2020
@boegel boegel marked this pull request as ready for review November 26, 2020 13:22
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2020

@ocaisa This should be good to go now, can you give it another look?

Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a typo, will take a deeper look while you fix that

Comment thread easybuild/framework/easyconfig/tools.py Outdated
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one minor request

Comment thread test/framework/options.py
@migueldiascosta
Copy link
Copy Markdown
Member

also lgtm, fwiw (and more importantly, it works! :) )

@ocaisa ocaisa merged commit 0fb8d5e into easybuilders:develop Nov 30, 2020
@boegel boegel deleted the copy-ec-from-pr branch November 30, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eb --copy-ec does not work with --from-pr yet

3 participants