Skip to content

don't pass username in github_api_get_request when no GitHub token is available#3494

Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:from_pr_no_github_token
Nov 11, 2020
Merged

don't pass username in github_api_get_request when no GitHub token is available#3494
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:from_pr_no_github_token

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 2, 2020

fixes #2921

@boegel boegel added the bug fix label Nov 2, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 2, 2020
migueldiascosta
migueldiascosta previously approved these changes Nov 3, 2020
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread easybuild/tools/github.py Outdated
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 444b980 into easybuilders:develop Nov 11, 2020
@boegel boegel deleted the from_pr_no_github_token branch November 12, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--from-pr & co should not pass GitHub login ID when no token is available

2 participants