enable code linting check for all supported Python versions#3725
enable code linting check for all supported Python versions#3725boegel merged 8 commits intoeasybuilders:developfrom
Conversation
|
seems to work, tests fail because we're now catching errors:
|
JensTimmerman
changed the title
|
@boegel This looks ok to me, and the caught error might need to be fixed .... |
|
@JensTimmerman could you do "eb --sync-pr-with-develop 3725 --pr-target-repo easybuild-framework" on this one to make sure it's up to date. |
|
@akesandgren that didn't seem to work for me, I just merged develop into this branch, if that also works for you? |
It did exactly what it needed to do, make sure that it applies on top of current develop HEAD and re-kick the test suite. You could also add a small fix for the line redefined problem it detects, not sure what @boegel would accept here but I think |
py3 functions will always fail in py2, so ignore for linting for now. c
| - name: Run flake8 to verify PEP8-compliance of Python code | ||
| run: | | ||
| flake8 | ||
| flake8 --exclude ./easybuild/tools/py2vs3/py3.py |
There was a problem hiding this comment.
ideally this only get's skipped for python2, but I couldn't quickly find a good filter for this case.
boegel
changed the title
|
Thanks a lot @JensTimmerman! |
enable code linting check for all supported Python versions
3 participants
run linting tests for all supported python versions