fall back to sequential installation for extensions with unknown dependencies when using --parallel-extensions-install#3906
Merged
branfosj merged 2 commits intoeasybuilders:developfrom Dec 4, 2021
Conversation
…termined, and only install it when preceding extensions have been installed
…custom toy easyblock that doesn't implement required_deps
63c615a to
ff98040
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a hard crash that occurs currently when trying to use
--parallel-extensions-install --experimental --robotand an easyconfig that includes Python packages as extensions.For example:
This occurs because the
PythonPackageeasyblock does not define therequired_depsmethod, and hence the default implementation from theExtensioneasyblock is used.The changes include here include:
required_depsto just returnNone;The added test verifies that this is working as expected.