print potential errors after running a command only once#4065
Merged
smoors merged 1 commit intoeasybuilders:developfrom May 12, 2023
Merged
print potential errors after running a command only once#4065smoors merged 1 commit intoeasybuilders:developfrom
smoors merged 1 commit intoeasybuilders:developfrom
Conversation
smoors
reviewed
Feb 27, 2023
Contributor
Author
|
@smoors Could you merge those as the only failing checks are the now-removed bootstrap tests? Or shall I rebase to rerun the CI? |
Contributor
i cannot merge before all tests are green. |
`parse_cmd_output` calls `parse_log_for_error` which outputs potential errors by default via `log.info`. The former then outputs those via `log.warning` again. Fix this by passing `stdout=False` to the latter. Also minor rewording and variable renaming.
Contributor
Author
|
They will fail. I rebased. |
Contributor
|
Going in, thanks @Flamefire! |
boegel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_cmd_outputcallsparse_log_for_errorwhich outputs potentialerrors by default via
log.info.The former then outputs those via
log.warningagain.Fix this by passing
stdout=Falseto the latter.Also minor rewording and variable renaming.