Skip to content

add Ubuntu friendly package naming scheme EasyBuildDebFriendlyPNS#4115

Merged
ocaisa merged 16 commits intoeasybuilders:developfrom
vcc-caeit:Ubuntu_Friendly_PNS
Jan 13, 2023
Merged

add Ubuntu friendly package naming scheme EasyBuildDebFriendlyPNS#4115
ocaisa merged 16 commits intoeasybuilders:developfrom
vcc-caeit:Ubuntu_Friendly_PNS

Conversation

@marbud0
Copy link
Copy Markdown
Contributor

@marbud0 marbud0 commented Oct 27, 2022

Simple new PNS that complies with the deb policy rule: version has to start with a number.

The standard EB PNS generates version strings beginning with eb_. This is violating the Debian package version string policy requirement of the version string always starting with a number.
This is a implimentation of a new PNS called EasyBuildDebFriendlyPNS that postfix eb to the version string instead of prefixing and also add a 0 to any upstream version string NOT starting with a number

@marbud0 marbud0 force-pushed the Ubuntu_Friendly_PNS branch from e451e95 to 3135142 Compare November 2, 2022 13:32
@marbud0 marbud0 marked this pull request as ready for review November 2, 2022 13:35
@marbud0 marbud0 changed the title {dummy}[dummy] EasyBuild 4.6.2 Ubuntu friendly PNS EasyBuild 4.6.2 Ubuntu friendly PNS Nov 3, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 3, 2022

@marbud0 Are you up for making sure that this package naming scheme is covered by the tests?
See test/framework/package.py

@boegelbot

This comment was marked as outdated.

@marbud0
Copy link
Copy Markdown
Contributor Author

marbud0 commented Nov 3, 2022

Not sure where to add a test that would use the new deb friendly PNS. Is that controlled from the test execution env or should I somehow set the PNS from the test code? (Assumed the first for now..)

@marbud0
Copy link
Copy Markdown
Contributor Author

marbud0 commented Nov 7, 2022

Don't feel responsible for the EasyBuild framework unit tests / build (3.6, Lmod-8.7.6, Tcl) (pull_request) failure during the last run.. (Network unreachable...)... Not sure about EasyBuild framework unit tests / build (2.7, Lmod-7.8.22, Tcl) (pull_request)... Please advice.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Nov 7, 2022

Don't feel responsible for the EasyBuild framework unit tests / build (3.6, Lmod-8.7.6, Tcl) (pull_request) failure during the last run.. (Network unreachable...)... Not sure about EasyBuild framework unit tests / build (2.7, Lmod-7.8.22, Tcl) (pull_request)... Please advice.

I triggered a rerun on both failing tests and they both passed. We do see intermittent failures.

@boegel boegel added this to the 4.x milestone Jan 11, 2023
@marbud0 marbud0 force-pushed the Ubuntu_Friendly_PNS branch from 92ef6ff to fa64085 Compare January 12, 2023 12:52
Comment thread test/framework/package.py Outdated
Comment thread test/framework/package.py Outdated
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 13, 2023

Going in, thanks @marbud0 !

@ocaisa ocaisa merged commit d725dba into easybuilders:develop Jan 13, 2023
@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Jan 13, 2023
@boegel boegel changed the title EasyBuild 4.6.2 Ubuntu friendly PNS add Ubuntu friendly package naming scheme EasyBuildDebFriendlyPNS Jan 13, 2023
@marbud0
Copy link
Copy Markdown
Contributor Author

marbud0 commented Jan 13, 2023

Thank you for the Review and help with the tests @ocaisa !

@marbud0 marbud0 deleted the Ubuntu_Friendly_PNS branch January 13, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants