Ignore request for external module (meta)data when no modules tool is active#4308
Merged
boegel merged 1 commit intoeasybuilders:developfrom Aug 11, 2023
Merged
Conversation
… active E.g. for `--fetch` the modules tool is explicitly set to `None`/`NoModulesTool` to allow running on e.g. laptops to fetch sources. This however fails for external module dependencies in which it tries to resolve them using the modules tool which fails with `NotImplementedError`. Simply ignore the request in that case as-if the module metadata wasn't found. Fixes easybuilders#4298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. for
--fetchthe modules tool is explicitly set toNone/NoModulesToolto allow running on e.g. laptops to fetch sources. This however fails for external module dependencies in which it tries to resolve them using the modules tool which fails withNotImplementedError.Simply ignore the request in that case as-if the module metadata wasn't found.
Fixes #4298
Alternative to and hence closes #4299
I also found a test case which reproduces this: Running
--fetchwith toy-0.0-deps.eb