add support for --from-commit and --include-easyblocks-from-commit#4468
Merged
branfosj merged 15 commits intoeasybuilders:developfrom Apr 3, 2024
Merged
add support for --from-commit and --include-easyblocks-from-commit#4468branfosj merged 15 commits intoeasybuilders:developfrom
--from-commit and --include-easyblocks-from-commit#4468branfosj merged 15 commits intoeasybuilders:developfrom
Conversation
…tarball was actually downloaded + add extra test for download_repo with commit
--from-commit--from-commit and --include-easyblocks-from-commit
…lean up imported easyblock
branfosj
requested changes
Apr 3, 2024
…ommit ID) Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
branfosj
requested changes
Apr 3, 2024
Member
branfosj
left a comment
There was a problem hiding this comment.
If I do eb --from-pr=20102 --from-commit=6a7085ddddc63cbfc5fb4f68b522f2bb00de2b22 then the --from-commit is ignored. It would be good to either:
- add a warning message
- fail out on these not being allowed together
…from-commit and --include-easyblocks-from-pr are combined
…de-easyblocks-from-pr if --include-easyblocks is not used (cfr. failing test_github_xxx_include_easyblocks_from_pr)
Member
Author
Combination of |
branfosj
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP because some things are still missing:
download_repofunction to cover newcommitoption;fetch_files_from_commitandfetch_easyconfigs_from_commitfunctions;--from-commitoption;--include-easyblocks-from-commitoption + dedicated test;--copy-ecand--from-commit