Skip to content

add support for --from-commit and --include-easyblocks-from-commit#4468

Merged
branfosj merged 15 commits intoeasybuilders:developfrom
boegel:from_commit
Apr 3, 2024
Merged

add support for --from-commit and --include-easyblocks-from-commit#4468
branfosj merged 15 commits intoeasybuilders:developfrom
boegel:from_commit

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 29, 2024

WIP because some things are still missing:

  • enhanced test for download_repo function to cover new commit option;
  • dedicated test for fetch_files_from_commit and fetch_easyconfigs_from_commit functions;
  • dedicated test for --from-commit option;
  • also implement --include-easyblocks-from-commit option + dedicated test;
  • fix combo of --copy-ec and --from-commit

boegel added 2 commits March 11, 2024 09:59
…tarball was actually downloaded + add extra test for download_repo with commit
@boegel boegel changed the title add support for --from-commit add support for --from-commit and --include-easyblocks-from-commit Mar 13, 2024
@boegel boegel marked this pull request as ready for review April 2, 2024 20:35
Comment thread easybuild/tools/github.py
Comment thread test/framework/github.py Outdated
Comment thread test/framework/robot.py Outdated
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do eb --from-pr=20102 --from-commit=6a7085ddddc63cbfc5fb4f68b522f2bb00de2b22 then the --from-commit is ignored. It would be good to either:

  • add a warning message
  • fail out on these not being allowed together

Comment thread easybuild/tools/options.py
boegel added 2 commits April 3, 2024 21:03
…from-commit and --include-easyblocks-from-pr are combined
…de-easyblocks-from-pr if --include-easyblocks is not used (cfr. failing test_github_xxx_include_easyblocks_from_pr)
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 3, 2024

If I do eb --from-pr=20102 --from-commit=6a7085ddddc63cbfc5fb4f68b522f2bb00de2b22 then the --from-commit is ignored. It would be good to either:

* add a warning message

* fail out on these not being allowed together

Combination of --*from-commit and --*from-pr is now disallowed, see 6968f87

@branfosj branfosj enabled auto-merge April 3, 2024 19:36
@branfosj branfosj merged commit dda2fd4 into easybuilders:develop Apr 3, 2024
@boegel boegel deleted the from_commit branch April 3, 2024 20:02
@boegel boegel added the EESSI Related to EESSI project label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EESSI Related to EESSI project enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants