add support for using list of values in modulename in extensions#4716
Merged
smoors merged 5 commits intoeasybuilders:developfrom Mar 15, 2026
Merged
add support for using list of values in modulename in extensions#4716smoors merged 5 commits intoeasybuilders:developfrom
modulename in extensions#4716smoors merged 5 commits intoeasybuilders:developfrom
Conversation
Flamefire
force-pushed
the
multiple-modulenames
branch
from
bd305b1 to
7dac45e
Compare
Member
|
@Flamefire I changed to target branch in this PR from |
Flamefire
force-pushed
the
multiple-modulenames
branch
from
5e09ede to
c1b87f3
Compare
Contributor
Author
|
Rebased |
Flamefire
force-pushed
the
multiple-modulenames
branch
from
7b32a03 to
05716cc
Compare
This changes the allowed types of the `modulename` extension option: - `False` to skip the sanity check and always install it when `--skip` is used - `str`: Value for `%(ext_name)s` in the `exts_filter` template - List of `str`: Multiple names to be used in the `exts_filter` template. All resulting commands must succeed. It replaces `resolve_exts_filter_template` by `construct_exts_filter_cmds` as the method now returns a, potentially empty, list which might cause errors if used without expecting a list.
There shouldn't be a command executed for that.
Flamefire
force-pushed
the
multiple-modulenames
branch
from
5ccc99a to
d0eb465
Compare
smoors
reviewed
Feb 27, 2026
This might be useful for easyblocks to avoid duplicating the code for determining the modulename from either the options or the name.
Flamefire
force-pushed
the
multiple-modulenames
branch
from
d0eb465 to
f2ca644
Compare
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Flamefire
force-pushed
the
multiple-modulenames
branch
from
b7f52fd to
08eb033
Compare
Contributor
Author
|
@smoors I did the changes we discussed (didn't get a notification for the thumbs up so I missed them until yesterdays confcall) |
smoors
reviewed
Mar 14, 2026
smoors
approved these changes
Mar 15, 2026
Contributor
smoors
left a comment
smoors
left a comment
There was a problem hiding this comment.
tested on a customized Arrow-22.0.0-gfbf-2025a.eb, works like a charm
# multiple modulenames
'modulename': ['pyarrow', 'pyarrow.dataset', 'pyarrow.parquet', 'pyarrow.orc'],
# no modulename
'modulename': False,
boegel
changed the title
modulename in extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the allowed types of the
modulenameextension option:Falseto skip the sanity check and always install it when--skipis usedstr: Value for%(ext_name)sin theexts_filtertemplatestr: Multiple names to be used in theexts_filtertemplate. All resulting commands must succeed.This was previously suggested to allow Perl modules that are part of other Perl modules and hence don't need to be installed multiple times. See easybuilders/easybuild-easyconfigs#12575
It replaces
resolve_exts_filter_templatebyconstruct_exts_filter_cmdsas the method now returns a, potentially empty, list which might cause errors if used without expecting a list.The function is only used internally in framework and not by any easyblocks.