do not determine number of iterations in easyblock constructor (which is too early), but in run_all_steps#4952
Merged
boegel merged 2 commits intoeasybuilders:developfrom Jul 4, 2025
Merged
Conversation
boegel
previously approved these changes
Jul 4, 2025
Member
|
Without this fix, the installation of More specifically, the additional build stages that the easyblock should do for the @branfosj Thanks a lot for figuring this out! |
Member
|
This bug also affects other software-specific easyblocks where we get creative with iterations, like |
det_iter_cnt() in the __init__det_iter_cnt() in the __init__, but in run_all_steps
det_iter_cnt() in the __init__, but in run_all_stepsrun_all_steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4919 calls
det_iter_cnt()too early.If we call
det_iter_cnt()in the__init__then we do this before we initialise the easyblock for the specific bit of software, so we do not know how many iterations there are. This means we fix on one iteration.