Skip to content

Incompatibility with vscode-languageclient < 6.0.0 #407

@JanKoehnlein

Description

@JanKoehnlein

VS Code initially added the PublishDiagnosticsCapabilities#tagSupport as boolean in the vscode-language-client implementation, but without adding it to the LSP spec. In LSP 3.15 it was finally speced out as being of type DiagnosticsTagSupport and the client implementation was adapted in version 6.0.0.

So all clients relying on vscode-language-client < 6.0.0 will fail to connect to a lsp4j server as it cannot parse their initialize request. Unfortunately, that includes the monaco-language-client, and thereby all extensions to Eclipse Theia. It's unlikely this can be fixed within the next weeks.

For the time being, I'd propose to change the type of PublishDiagnosticsCapabilities#tagSupport to Either<Boolean, DiagnosticsTagSupport>.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions