Closing of StreamMessageProducer does not work reliable

[OhioDschungel6]

def messageProducer = new StreamMessageProducer(para,para)
 ForkJoinPool.commonPool().submit(() -> messageProducer.listen(endpoint))
messageProducer.close()

In this code i would expect that the thread will be stopped.
In reality the StreamMessageProducer does not close properly, because only a boolean flag is toggled, but it could be already in a blocking state, because input.read is a blocking call.

I fixed the issue in the following PR:
#967

[pisv]

@OhioDschungel6 Thanks, and sorry for a delay in responding.

I don't think there is anything to fix here.

In the above example, after calling messageProducer.close() you need to interrupt the listening thread by calling cancel(true) on the future returned from the submit call. This is the correct way to solve your problem.

In practice, you just need to call cancel(true) on the future returned from the launcher.startListening() call, which will both close the message producer and interrupt the listening thread:

lsp4j/org.eclipse.lsp4j.jsonrpc/src/main/java/org/eclipse/lsp4j/jsonrpc/json/ConcurrentMessageProcessor.java

Lines 52 to 61 in 81a12f0

	public boolean cancel(boolean mayInterruptIfRunning) {
	if (mayInterruptIfRunning && messageProducer instanceof Closeable) {
	try {
	((Closeable) messageProducer).close();
	} catch (IOException e) {
	throw new RuntimeException(e);
	}
	}
	return result.cancel(mayInterruptIfRunning);
	}

For details, see our documentation.