Skip to content

fix(excel import): improved error messages shown in excel formula information#1036

Merged
tom-rm-meyer-ISST merged 9 commits intoeclipse-tractusx:mainfrom
achtzig20:fix/update-error-messages-excel-import
Nov 11, 2025
Merged

fix(excel import): improved error messages shown in excel formula information#1036
tom-rm-meyer-ISST merged 9 commits intoeclipse-tractusx:mainfrom
achtzig20:fix/update-error-messages-excel-import

Conversation

@OlgaIvkovic
Copy link
Copy Markdown
Contributor

@OlgaIvkovic OlgaIvkovic commented Oct 26, 2025

improved error messages shown in excel formula information for excel import

  • Formula evaluation on excel import now provides error messages more understandable to the user

Description

Fixes #1034

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Makes the software already much more reliable! :)

Found a few smaller needs for improvements.

Comment thread CHANGELOG.md Outdated
Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java
Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
tom-rm-meyer-ISST
tom-rm-meyer-ISST reviewed Nov 6, 2025
View reviewed changes
Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
Comment on lines +788 to +791
if (ex.getCause() instanceof NotImplementedFunctionException){
log.error("Runtime Exception is notImplementedFunction");
}
log.error("RUntime exception cause is: " + ex.getCause().toString());
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the misunderstanding. The snippet has only been meant as an example for catching the inner cause. Please implement the triple check (else-ifs / switch) on NotImplementedFunctionException, FormulaParseException and a fallback, same as before. The error messages were much better!

Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, please reincorporate some error handling.

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is great, but spotted a typo in remaining log message.

Please fix and we're ready to go! :)

Comment thread backend/src/main/java/org/eclipse/tractusx/puris/backend/file/logic/service/ExcelService.java Outdated
@OlgaIvkovic
Copy link
Copy Markdown
Contributor Author

OlgaIvkovic commented Nov 10, 2025

Hi Tom! The check kept failing so I decided to revert the changes with the file name, hope that's okay

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating over this with me!

Yeah, user inputs with CodeQl are tedious. Feel free to discuss these with me. We use the PatternStore non-whitespace or whitespace related pattern in the controllers. On Service Level the check still raises vulnerabilities, but IMHO this is false positive!

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title improved error messages shown in excel formula information for excel import fix(excel import): improved error messages shown in excel formula information Nov 11, 2025
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit d6ae7f4 into eclipse-tractusx:main Nov 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Error in Excel Formula Information leads to non-understandable errror description to the user

3 participants

@OlgaIvkovic @github-advanced-security @tom-rm-meyer-ISST
⚡