feat: added create material feature for admins#1044
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
OlgaIvkovic
changed the base branch from
main
to
feat/create-master-data-via-ui
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
Only smaller findings / improvements :)
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 5.1.1 | ||
| version: 5.1.2 |
There was a problem hiding this comment.
Chart version should be bumped same as app version. If there is a breaking change in the interfaces, it should be major, else minor.
Here I would go for minor, as we got non-breaking additional functionality.
Please also bump app-version + respective files in frontend / backend / Changelog.
| ### Added | ||
|
|
||
| - added detailed error messages for formulas in excel imports ([#1036](https://github.com/eclipse-tractusx/puris/pull/1036)) | ||
| - added Master data page for viewing all materials and option to add material as an admin ([#1044](https://github.com/eclipse-tractusx/puris/pull/1044)) |
There was a problem hiding this comment.
4.1.1 already released. Pleas bump minor and take over known knowns
| /> | ||
| </Grid> | ||
| <Grid item xs={12}> | ||
| <InputLabel>Global Asset Id {config.app.GENERATE_MATERIAL_CATENAX_ID && '*'}</InputLabel> |
There was a problem hiding this comment.
I was wondering, if we need even to enable it in case we configured to generate the cx id. And we need, at least for the product case.
Nevertheless, the behavior might be confusing users:
- If I create a Material (inbound), I think I need to insert the GlobalAssetId of the supplier's twin. But I don't because PURIS FOSS will take over the uuid (one could also disable it if autogeneration is given)
- If I create a Product (outbound), I can insert the GlobalAssetId as this one is used to create the digital twin. If I don't specify it, it's needed.
I would not change it, but how about a tooltip:
"Your configurations does /does not generate the uuid for you. If you specify an outbound or bidirectional twin (a product), it makes sense to specify the uuid in case you want to also communicate this number to your customers."
Disabling it for inbound material when autogeneration is disabled could help, too. We definitely need it enabled for products for the community days.
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks. Please for next consider also run helm-docs to update the charts/README.md
tom-rm-meyer-ISST
merged commit 3cad949
into
eclipse-tractusx:feat/create-master-data-via-ui
3 participants
Description
Solves #1042
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: