Skip to content

feat: added component to copy identifiers in material list view to clipboard#1058

Merged
tom-rm-meyer-ISST merged 13 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/copy-identifiers-in-material-list-view
Jan 12, 2026
Merged

feat: added component to copy identifiers in material list view to clipboard#1058
tom-rm-meyer-ISST merged 13 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/copy-identifiers-in-material-list-view

Conversation

@jakoballgaier
Copy link
Copy Markdown
Contributor

@jakoballgaier jakoballgaier commented Dec 1, 2025

Description

  • added a component to copy text to clipboard

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@jakoballgaier jakoballgaier self-assigned this Dec 1, 2025
@jakoballgaier jakoballgaier changed the title Feat/copy identifiers in material list view feat: added component to copy identifiers in material list view to clipboard Dec 1, 2025
@jakoballgaier jakoballgaier removed their assignment Dec 2, 2025
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Dec 11, 2025 that may be closed by this pull request
[Story] Allow to copy material number and other identifiers in Material (List) View #980
Closed
20 tasks
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contirbution!

Overall looks fine but found smaller things to please incorporate. Please check for issue #980 . One point is missing (material details view, material information in the beginning.

If you update that, it would also be great to switch from (material number), (direction) to (material number, direction). Thanks in advance.

Comment thread CHANGELOG.md Outdated
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v4.1.2
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to latest version

Comment thread frontend/src/components/ui/TextToClipboard.tsx Outdated
Comment thread frontend/src/components/ui/TextToClipboard.tsx
@jakoballgaier
feat: copy material number and other identifiers in material list view
3ab2a3e 
- added component to copy text to clipboard
- adjusted modal width
- split up order reference into own columns
@jakoballgaier
fix: PR changes for copy material number and other identifiers in mat…
d5a7ad1 
…erial list view

- added license header
- add variant to TextToClipboard component
- made text of TextToClipboard not nullable
@jakoballgaier
Revert "feat: add environments for running frontends without containers"
efd22d2 
This reverts commit 8b56a38.
@jakoballgaier
Update CHANGELOG.md
7d78522
@jakoballgaier jakoballgaier force-pushed the feat/copy-identifiers-in-material-list-view branch from 34e7c78 to 7d78522 Compare December 18, 2025 13:18
@jakoballgaier
fix: PR changes for copy material number and other identifiers in mat…
3060413 
…erial list view

- Fix copyright year
- Return null in TextToClipboard component if text is empty
- Add TextToClipboard component to material details header
@jakoballgaier
fix: PR changes for copy material number and other identifiers in mat…
919e420 
…erial list view

- change material details header format
@jakoballgaier
Revert "feat: add environments for running frontends without containers"
8852868 
This reverts commit 8b56a38.
@jakoballgaier
Copy link
Copy Markdown
Contributor Author

jakoballgaier commented Dec 18, 2025

@tom-rm-meyer-ISST
Thanks for your review! I updated the PR according to your suggestions

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase /merge main again. Sorry missed the rereview request as I got some outlook rules that delete a lot that's not a review requested.

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comment for package-lock.json

Comment thread frontend/package-lock.json Outdated
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 950eb84 into eclipse-tractusx:main Jan 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Story] Allow to copy material number and other identifiers in Material (List) View

2 participants

@jakoballgaier @tom-rm-meyer-ISST
⚡